Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute variable names for joins in R #3430

Merged
merged 11 commits into from Mar 16, 2018
Merged

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Mar 16, 2018

Closes #3425.

Also fixes #3266 and fixes #3417.

@krlmlr krlmlr force-pushed the f-#3425-join-r branch 5 times, most recently from 7ed1ad4 to 0a56b63 Mar 16, 2018
@krlmlr krlmlr force-pushed the f-#3425-join-r branch from 0a56b63 to 214e654 Mar 16, 2018
@krlmlr krlmlr requested a review from romainfrancois Mar 16, 2018
@krlmlr krlmlr merged commit 302aec4 into tidyverse:master Mar 16, 2018
4 checks passed
@krlmlr krlmlr deleted the f-#3425-join-r branch Mar 16, 2018
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Mar 16, 2018

@romainfrancois: Still happy to take your feedback if you have the time.

krlmlr added a commit that referenced this issue Mar 16, 2018
* Show clear error message for bad arguments to `funs()` (#3368).

* Improved documentation for `funs()` (#3094).

* Compute variable names for joins in R (#3430).

* Hybrid evaluation simplifies `dplyr::foo` to `foo` (#3309).

* `bind_cols()` handles unnamed list (#3402).
@lock
Copy link

@lock lock bot commented Sep 12, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant