Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reindexing grouped data frames only update class if not grouped already #3438

Merged
merged 3 commits into from Mar 20, 2018

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Mar 16, 2018

to retain existing classes. Closes #3310.

Does the comment make sense?

@krlmlr krlmlr requested a review from romainfrancois Mar 16, 2018
to retain existing classes
@krlmlr krlmlr force-pushed the b-#3310-reindex-class branch from 08d4133 to 3d99e83 Mar 18, 2018
Copy link
Member

@romainfrancois romainfrancois left a comment

I'm fine with the comment.

Isn't r_match too big a 🔨 ?

btw, there is this function in tbl_cpp.h

template <typename Data>
inline Rcpp::CharacterVector classes_grouped() {
  return Rcpp::CharacterVector::create("grouped_df", "tbl_df", "tbl", "data.frame");
}

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Mar 19, 2018

Thanks. Yeah, should be Rf_inherits(). Will update, and also use the helper.

@krlmlr krlmlr merged commit 84fdff5 into tidyverse:master Mar 20, 2018
4 checks passed
@krlmlr krlmlr deleted the b-#3310-reindex-class branch Mar 20, 2018
@lock
Copy link

@lock lock bot commented Sep 16, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants