scoped variants of arrange() respect the .by_group argument #3504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
reviewed
May 2, 2018
| @@ -5,6 +5,7 @@ | |||
| #' variables before ordering with [funs()]. | |||
| #' | |||
| #' @inheritParams scoped | |||
| #' @param .by_group see [arrange()] | |||
R/colwise-arrange.R
Outdated
| if (inherits(.tbl, "grouped_df")){ | ||
| arrange(.tbl, !!!funs, .by_group = .by_group) | ||
| } else { | ||
| arrange(.tbl, !!!funs) |
There was a problem hiding this comment.
Can we supply a .by_group argument to arrange.tbl_df() instead, and ignore it there? The patch would be smaller.
There was a problem hiding this comment.
And just ignore it in arrange.tbl_df ?
|
Thanks! I'll tweak it a bit. |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3245.