Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in top_n function to return specified rows #367

Merged
merged 4 commits into from Apr 9, 2014

Conversation

@leondutoit
Copy link
Contributor

@leondutoit leondutoit commented Apr 2, 2014

tbl %.% ... %.% top_n(n) now returns n rows instead of n-1.

leondutoit and others added 3 commits Apr 2, 2014
tbl %.% ... %.% top_n(n) now returns n rows instead of n-1.
To make sure it returns n rows.
@hadley
Copy link
Member

@hadley hadley commented Apr 2, 2014

Would you mind also adding a bullet point to NEWS.md acknowledging yourself? Thanks!

Loading

@leondutoit
Copy link
Contributor Author

@leondutoit leondutoit commented Apr 2, 2014

Done.
Happy to make a small contribution to this wonderful library.

Loading

@hadley hadley merged commit 4fb458f into tidyverse:master Apr 9, 2014
1 check passed
Loading
@hadley
Copy link
Member

@hadley hadley commented Apr 9, 2014

Thanks!

Loading

@lock
Copy link

@lock lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

Loading

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants