Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rchk errors #3693

Merged
merged 5 commits into from Jun 25, 2018
Merged

Fix rchk errors #3693

merged 5 commits into from Jun 25, 2018

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jun 22, 2018

https://raw.githubusercontent.com/kalibera/cran-checks/master/rchk/results/dplyr.out

@krlmlr krlmlr requested a review from romainfrancois Jun 22, 2018
@krlmlr krlmlr added this to the 0.7.6 milestone Jun 23, 2018
@krlmlr krlmlr requested a review from lionel- Jun 25, 2018
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Jun 25, 2018

Unfortunately, these errors don't show up on rhub (but a new error does). Will merge, submit to CRAN and hope that at least some of the errors disappear.

https://builder.r-hub.io/status/dplyr_0.7.6.tar.gz-649269d951c84f8e98fffaebbcec3a71

@lionel-
Copy link
Member

@lionel- lionel- commented Jun 25, 2018

With the bools created outside of create()?

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Jun 25, 2018

A completely different set of errors is reported on rhub, this particular error doesn't show at all on rhub.

@gaborcsardi: We're seeing different output from CRAN's rchk and rhub's rchk. What could be the reason? (Thanks for providing the service!)

@gaborcsardi
Copy link
Member

@gaborcsardi gaborcsardi commented Jun 25, 2018

Rhub's rchk is older, and I could not update it so far.

romainfrancois
Copy link
Member

romainfrancois commented on 3a99592 Jun 25, 2018

if this is a protection issue, it's the RObject that needs to stay protected, e.g. :

RObject small_obj(wrap(small)) ;
... 
LogicalVector::create( as<double>(small_obj) == (double)small, ...);
krlmlr
Copy link
Member

krlmlr commented on 3a99592 Jun 25, 2018

Good catch, changed now.

@krlmlr krlmlr merged commit 622fa98 into tidyverse:r-0.7.6 Jun 25, 2018
0 of 2 checks passed
@krlmlr krlmlr deleted the b-rchk branch Jun 25, 2018
@lock
Copy link

@lock lock bot commented Dec 22, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Dec 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants