Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soft deprecate funs() #3930

Merged
merged 15 commits into from Oct 26, 2018
Merged

soft deprecate funs() #3930

merged 15 commits into from Oct 26, 2018

Conversation

romainfrancois
Copy link
Member

@romainfrancois romainfrancois commented Oct 22, 2018

Still need to:

  • actually soft deprecate funs()
  • should we keep the tests in test-funs.R

I replaced tests and various mentions of funs in the documentation by using list (sometimes named).

@romainfrancois romainfrancois requested review from lionel- and krlmlr Oct 22, 2018
@romainfrancois romainfrancois changed the title deprecate funs() soft deprecate funs() Oct 22, 2018
@hadley
Copy link
Member

@hadley hadley commented Oct 22, 2018

I think for this release we should probably do a soft-deprecation (i.e. no warning), and then warn in the next release (i.e. file an issue to hard deprecate)

@romainfrancois romainfrancois added this to the 0.8.0 milestone Oct 22, 2018
@lionel-
Copy link
Member

@lionel- lionel- commented Oct 22, 2018

A character vector of function names,

Perhaps we don't want to document this? This is a consequence of using rlang::as_function() (previously purrr::as_function(), but I don't know if we want to promote this as a style of programming, especially since people might take and pass these strings in functions and then we might not pick up from the correct environment.

@hadley
Copy link
Member

@hadley hadley commented Oct 22, 2018

Yeah, I'd recommend either fun, ~ fun(.x), or lists of either form. (Then mention rlang::as_function() in a parenthetical.

@romainfrancois romainfrancois merged commit 2e6ca16 into master Oct 26, 2018
3 of 4 checks passed
@romainfrancois romainfrancois deleted the 3433/deprecate-funs branch Oct 26, 2018
@lock
Copy link

@lock lock bot commented Apr 24, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants