Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace data_frame() by tibble() #4117

Merged
merged 15 commits into from Jan 23, 2019
Merged

Conversation

@Copepoda
Copy link
Contributor

Copepoda commented Jan 19, 2019

Changed data_frame() to tibble() in dplyr from issue 4096

Original issue:
This issue is to be dealt with on Tidyverse developer day 2019. 馃檹 don't submit pull requests for it outside of the event. We are of course interested in having this fixed, but much more interested in doing it as part of the developer day

identify uses of the deprecated function data_frame() in the dplyr codebase: code, docs, tests, vignette.
replace with uses of tibble()

@romainfrancois romainfrancois self-requested a review Jan 19, 2019
Copy link
Member

romainfrancois left a comment

Thanks. That looks great. I think we'd just need to revert the changes on the NEWS.md file

NEWS.md Outdated Show resolved Hide resolved
@romainfrancois

This comment has been minimized.

Copy link
Member

romainfrancois commented Jan 19, 2019

@Copepoda I noticed that you used the same commit message for all commits. That makes it slightly harder to grasp what each commit is about specifically. This is just a comment, you don't need to change anything now.

Nissa Ferm
This reverts commit da12be9.
@romainfrancois

This comment has been minimized.

Copy link
Member

romainfrancois commented Jan 19, 2019

Great. I just noticed that we are in a similar situation with as_data_frame() being deprecated and replaced by as_tibble().

I can open another issue, but it feels like we could tackle it here since it's very similar

@Copepoda

This comment has been minimized.

Copy link
Contributor Author

Copepoda commented Jan 19, 2019

Great. I just noticed that we are in a similar situation with as_data_frame() being deprecated and replaced by as_tibble().

I can open another issue, but it feels like we could tackle it here since it's very similar

done 馃憤

@romainfrancois

This comment has been minimized.

Copy link
Member

romainfrancois commented Jan 19, 2019

Thanks. That looks good. I'll merge this once we get from travis.

@romainfrancois romainfrancois changed the title Issue 4069 df Replace data_frame() by tibble() Jan 19, 2019
@romainfrancois

This comment has been minimized.

Copy link
Member

romainfrancois commented Jan 23, 2019

closes #4096

@romainfrancois romainfrancois merged commit d2e77ee into tidyverse:master Jan 23, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 84.13% (target 70%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@romainfrancois

This comment has been minimized.

Copy link
Member

romainfrancois commented Jan 23, 2019

Thanks again @Copepoda for dealing with this issue on developer day 馃憤

@Copepoda

This comment has been minimized.

Copy link
Contributor Author

Copepoda commented Jan 24, 2019

Awesome! Dev day was so much fun. :)

@lock

This comment has been minimized.

Copy link

lock bot commented Jul 23, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jul 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.