Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offered by CRAN. #4185

Merged
merged 2 commits into from Feb 15, 2019
Merged

Fix offered by CRAN. #4185

merged 2 commits into from Feb 15, 2019

Conversation

@romainfrancois
Copy link
Member

@romainfrancois romainfrancois commented Feb 15, 2019

No description provided.

Copy link
Member

@krlmlr krlmlr left a comment

Are we risking integer overflow anywhere?

@romainfrancois
Copy link
Member Author

@romainfrancois romainfrancois commented Feb 15, 2019

This was not what was complained about by cran.

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Feb 15, 2019

The integer overflow doesn't care, but I agree this has nothing to do with this particular PR.

@romainfrancois romainfrancois merged commit cdcb773 into master Feb 15, 2019
0 of 4 checks passed
@romainfrancois romainfrancois deleted the fix-from-cran-0.8.0.1 branch Feb 15, 2019
@lock
Copy link

@lock lock bot commented Aug 14, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants