Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates documentation to filter() #4820

Merged
merged 16 commits into from Jan 31, 2020
Merged

Updates documentation to filter() #4820

merged 16 commits into from Jan 31, 2020

Conversation

@djnavarro
Copy link
Contributor

djnavarro commented Jan 31, 2020

Various updates to the filter() documentation.

  • Adds brief introduction to make the "details" section less jarring
  • Minor tidying to text to improve readability
  • Attempts to describe the arguments more clearly
  • Removes "see alsos" that will be redundant in an across() workflow

Closes #4791. I hope 馃檪

Copy link
Member

hadley left a comment

Looks great overall, despite many the nits I have picked 馃槃

R/filter.R Outdated Show resolved Hide resolved
R/filter.R Outdated Show resolved Hide resolved
R/filter.R Outdated Show resolved Hide resolved
R/filter.R Show resolved Hide resolved
R/filter.R Outdated Show resolved Hide resolved
R/filter.R Show resolved Hide resolved
djnavarro and others added 2 commits Jan 31, 2020
Co-Authored-By: Hadley Wickham <h.wickham@gmail.com>
@djnavarro djnavarro requested a review from hadley Jan 31, 2020
@djnavarro

This comment has been minimized.

Copy link
Contributor Author

djnavarro commented Jan 31, 2020

I think this removes the relevant nits :-)

@hadley hadley merged commit 9498e58 into tidyverse:master Jan 31, 2020
9 checks passed
9 checks passed
windows-latest (3.6)
Details
macOS-latest (3.6)
Details
macOS-latest (devel) macOS-latest (devel)
Details
ubuntu-16.04 (3.2)
Details
ubuntu-16.04 (3.3)
Details
ubuntu-16.04 (3.4)
Details
ubuntu-16.04 (3.5)
Details
ubuntu-16.04 (3.6)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Copy link
Member

hadley commented Jan 31, 2020

Much better, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can鈥檛 perform that action at this time.