Skip to content

Supersede transmute() #6414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 30, 2022
Merged

Supersede transmute() #6414

merged 6 commits into from
Aug 30, 2022

Conversation

hadley
Copy link
Member

@hadley hadley commented Aug 18, 2022

No description provided.

@hadley hadley requested a review from DavisVaughan August 18, 2022 19:34
Copy link
Member

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more places to remove it from:

  • Switch to mutate(.keep = "none") in arrange_rows(), and also update the "Problem with the implicit `transmute()` step." error bullet

  • Mentioned once in ?dplyr_extending i.e. `transmute()` does the same then uses 1d `[`

  • dplyr.Rmd i.e. If you only want to keep the new variables, use `transmute()`

  • grouping.Rmd i.e. ### `mutate()` and `transmute()`. This doesn't even use transmute so you could just say mutate()

I think it automatically got removed from pkgdown, so thats good

R/transmute.R Outdated
#' @description
#' `r lifecycle::badge("superseded")`
#'
#' `transmute()` is like `mutate(.keep = "none")`; adds new variables and drops
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#' `transmute()` is like `mutate(.keep = "none")`; adds new variables and drops
#' `transmute()` is like `mutate(.keep = "none")`; it adds new variables and drops

R/transmute.R Outdated
Comment on lines 22 to 23
#' * Columns created or modified through `...` will be returned in the order
#' specified by `...`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#' * Columns created or modified through `...` will be returned in the order
#' specified by `...`.
#' * Columns created or modified through `...` will be returned in the order
#' specified by `...`.

R/transmute.R Outdated
#'
#' `transmute()` is like `mutate(.keep = "none")`; adds new variables and drops
#' existing ones. New variables overwrite existing variables of the same name.
#' Variables can be removed by setting their value to `NULL`. It's supersed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#' Variables can be removed by setting their value to `NULL`. It's supersed
#' Variables can be removed by setting their value to `NULL`. It's superseded

R/transmute.R Outdated
#'
#' `transmute()` creates a new data frame containing only the specified
#' computations. It's superseded because you can perform the same job
#' with `mutate(.keep = "none")`; it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

; it ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants