Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ungroup() doesn't respect dots #253

Closed
mgirlich opened this issue May 25, 2021 · 0 comments · Fixed by #255
Closed

ungroup() doesn't respect dots #253

mgirlich opened this issue May 25, 2021 · 0 comments · Fixed by #255

Comments

@mgirlich
Copy link
Collaborator

ungroup.dtplyr_step() always removes all groups instead of only the specified ones

library(dtplyr)
library(dplyr, warn.conflicts = FALSE)

dt <- lazy_dt(data.frame(x = 1, y = 1))
dt %>% 
  group_by(x, y) %>% 
  ungroup(x) %>% 
  group_vars()
#> character(0)

dt %>% 
  collect() %>% 
  group_by(x, y) %>% 
  ungroup(x) %>% 
  group_vars()
#> [1] "y"

Created on 2021-05-25 by the reprex package (v2.0.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant