Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join returns data.table #19

Merged
merged 4 commits into from Jun 19, 2016

Conversation

@krlmlr
Copy link
Member

krlmlr commented Mar 8, 2016

Fixes #16.

Result of join not tested yet!

Kirill Müller added 4 commits Mar 8, 2016
Kirill Müller
@hadley: This is based on the dplyr-rewrite branch (#1)
Kirill Müller
Kirill Müller
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 8, 2016

Current coverage is 65.28%

Merging #19 into master will increase coverage by +0.14% as of cd528cb

@@            master     #19   diff @@
======================================
  Files            8       8       
  Stmts          241     242     +1
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            157     158     +1
  Partial          0       0       
  Missed          84      84       

Review entire Coverage Diff as of cd528cb

Powered by Codecov. Updated on successful CI builds.

@krlmlr krlmlr changed the title WIP: Test result for join Test result type for join Mar 8, 2016
@krlmlr krlmlr changed the title Test result type for join WIP: Test result type for join Mar 8, 2016
@krlmlr krlmlr changed the title WIP: Test result type for join Join returns data.table Jun 19, 2016
@krlmlr krlmlr merged commit c614c2b into tidyverse:master Jun 19, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@krlmlr krlmlr deleted the krlmlr:feature/16-full-join-df branch Jun 19, 2016
krlmlr pushed a commit that referenced this pull request Jun 19, 2016
Kirill Müller
- `distinct()` gains `.keep_all` argument (#30, #31).
- Slightly improve test coverage (#6).
- Install `devtools` from GitHub on Travis (#32).
- Joins return `data.table`. Right and full join are now implemented (#16, #19).
- Remove warnings from tests (#4).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.