Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distinct() gains .keep_all argument #31

Merged
merged 1 commit into from Jun 19, 2016

Conversation

@krlmlr
Copy link
Member

krlmlr commented Jun 18, 2016

with implementation. Passes dplyr tests.

Fixes #30.

@krlmlr krlmlr force-pushed the krlmlr:f-#30-keep-all branch from 45457b9 to 8cda723 Jun 19, 2016
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 19, 2016

Current coverage is 66.93%

Merging #31 into master will increase coverage by 0.54%

@@             master        #31   diff @@
==========================================
  Files             8          8          
  Lines           241        245     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            160        164     +4   
  Misses           81         81          
  Partials          0          0          

Powered by Codecov. Last updated by d235839...8cda723

@krlmlr krlmlr merged commit 3a28d68 into tidyverse:master Jun 19, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
codecov/project 66.93% (+0.54%) compared to d235839
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@krlmlr krlmlr deleted the krlmlr:f-#30-keep-all branch Jun 19, 2016
krlmlr pushed a commit that referenced this pull request Jun 19, 2016
Kirill Müller
- `distinct()` gains `.keep_all` argument (#30, #31).
- Slightly improve test coverage (#6).
- Install `devtools` from GitHub on Travis (#32).
- Joins return `data.table`. Right and full join are now implemented (#16, #19).
- Remove warnings from tests (#4).
krlmlr pushed a commit to krlmlr/dplyr that referenced this pull request Jun 19, 2016
krlmlr added a commit to krlmlr/dplyr that referenced this pull request Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.