Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove almost all warnings from tests #4

Merged
merged 1 commit into from Mar 8, 2016
Merged

remove almost all warnings from tests #4

merged 1 commit into from Mar 8, 2016

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Mar 8, 2016

one remaining warning seems to be related to the "simplified" branch in magrittr.

@hadley: This is based on the dplyr-rewrite branch (#1)
@hadley
Copy link
Member

@hadley hadley commented Mar 8, 2016

I've added you as a collaborator - feel free to merge anything minor yourself.

krlmlr added a commit that referenced this issue Mar 8, 2016
@krlmlr krlmlr merged commit ec0aaea into tidyverse:master Mar 8, 2016
1 check failed
@krlmlr krlmlr deleted the feature/test-warnings branch Mar 8, 2016
krlmlr pushed a commit that referenced this issue Jun 19, 2016
- `distinct()` gains `.keep_all` argument (#30, #31).
- Slightly improve test coverage (#6).
- Install `devtools` from GitHub on Travis (#32).
- Joins return `data.table`. Right and full join are now implemented (#16, #19).
- Remove warnings from tests (#4).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants