Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove almost all warnings from tests #4

Merged
merged 1 commit into from Mar 8, 2016

Conversation

@krlmlr
Copy link
Member

krlmlr commented Mar 8, 2016

one remaining warning seems to be related to the "simplified" branch in magrittr.

Kirill Müller
@hadley: This is based on the dplyr-rewrite branch (#1)
@hadley

This comment has been minimized.

Copy link
Member

hadley commented Mar 8, 2016

I've added you as a collaborator - feel free to merge anything minor yourself.

krlmlr added a commit that referenced this pull request Mar 8, 2016
- Remove warnings from tests (#4).
@krlmlr krlmlr merged commit ec0aaea into tidyverse:master Mar 8, 2016
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@krlmlr krlmlr deleted the krlmlr:feature/test-warnings branch Mar 8, 2016
krlmlr pushed a commit that referenced this pull request Jun 19, 2016
Kirill Müller
- `distinct()` gains `.keep_all` argument (#30, #31).
- Slightly improve test coverage (#6).
- Install `devtools` from GitHub on Travis (#32).
- Joins return `data.table`. Right and full join are now implemented (#16, #19).
- Remove warnings from tests (#4).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.