Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass sort and suffix to #41

wants to merge 2 commits into from


Copy link

Allow passing of sort and suffix from dplyr to method in underlying join functions.

Fixes #40

Copy link

codecov-io commented Apr 19, 2017

Codecov Report

Merging #41 into master will decrease coverage by 0.58%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
- Coverage   78.01%   77.43%   -0.59%     
  Files           8        8              
  Lines         232      226       -6     
- Hits          181      175       -6     
  Misses         51       51
Impacted Files Coverage Δ
R/joins.R 100% <100%> (ø) ⬆️
R/utils.R 84.37% <0%> (-2.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ceec18...4f2658f. Read the comment docs.

Copy link

krlmlr commented Jun 29, 2017

This looks obsolete after #48.

@hadley hadley closed this in d9c7583 Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Joins with custom suffixes on tbl_dt()
3 participants