Added custom endpoint for bedrock provider - #441
Closed
billsanto wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
I'd like to add that we now have Bedrock in production and it would be convenient for our R researchers to have Ellmer support, since not everyone has the skills to use Python. Will it be possible to consider this anytime in the near future? |
Member
|
Sure, but could you call the argument |
hadley
reviewed
Jul 17, 2025
Comment on lines
+73
to
+75
| if (!is.null(endpoint) && nzchar(endpoint)) { | ||
| endpoint <- sub("/$", "", endpoint) | ||
| } |
Member
There was a problem hiding this comment.
I don't think this is necessary as req_url_path_append() will take care of any extra slashes.
hadley
reviewed
Jul 17, 2025
| ".amazonaws.com" | ||
| )) | ||
| # Use custom endpoint if provided, otherwise construct default | ||
| if (nzchar(provider@base_url)) { |
Member
There was a problem hiding this comment.
This default should be constructed in chat_aws_bedrock()
Member
|
Hmmm, I've renamed this file since you started working on it, so it might be easier for me just to do this. |
hadley
added a commit
that referenced
this pull request
Jul 17, 2025
Includes a few other miscellanous fixes since it looks like it's been a while since I ran these tests. Replaces #441
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My university uses a proxy to access AWS with its own domain name. Using provider-azure as an example, I added an "endpoint" parameter to the chat function, which, if non-empty, replaces the standard amazonaws.com URL. Anything that precedes the /model/ segment of the URL would be used for endpoint parameter in chat_aws_bedrock(). We don't include region in the URL, but if others do, then they would want to embed the region into the endpoint argument.