Repository navigation
fix(match_tools): Match tools in tool results as well - #693
Merged
Merged
Conversation
hadley
approved these changes
Aug 1, 2025
atheriel
pushed a commit
to robert-norberg/ellmer
that referenced
this pull request
Aug 20, 2025
This commit updates default_snowflake_credentials() to handle Privatelink account identifiers. It also fixes tidyverse#693. Signed-off-by: Aaron Jacobs <aaron.jacobs@posit.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
contents_replay()relies onmatch_tools()to resolve tool definitions, we also need to resolve tools in the@request@toolproperty of results.Without this, the tool request is properly restored through
contents_replay(), but the result will be missing the tool defintion. This affects shinychat because it only looks at the tool result when restoring a chat from bookmarked state (because the tool call is resolved we don't need to show the request).I have a fix in shinychat, but it'd be best for
match_tools(), at least when called throughcontents_replay()to return the full tool result.