Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NA in fct_inorder() #98

Merged
merged 2 commits into from Feb 10, 2018
Merged

Allow NA in fct_inorder() #98

merged 2 commits into from Feb 10, 2018

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Sep 27, 2017

and as_factor(). Closes #89.

@jimhester jimhester requested a review from hadley Feb 9, 2018
@jimhester
Copy link
Member

@jimhester jimhester commented Feb 9, 2018

The issue this fixes #89, is one of the most upvoted issues in all of the tidyverse packages, so it would be useful to review and merge this to close the issue.

@hadley hadley merged commit 59cbe63 into tidyverse:master Feb 10, 2018
3 checks passed
@krlmlr krlmlr deleted the b-#89-inorder-na branch Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants