New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NA in fct_inorder() #98

Merged
merged 2 commits into from Feb 10, 2018

Conversation

Projects
None yet
3 participants
@krlmlr
Copy link
Member

krlmlr commented Sep 27, 2017

and as_factor(). Closes #89.

krlmlr added some commits Sep 27, 2017

@jimhester jimhester requested a review from hadley Feb 9, 2018

@jimhester

This comment has been minimized.

Copy link
Member

jimhester commented Feb 9, 2018

The issue this fixes #89, is one of the most upvoted issues in all of the tidyverse packages, so it would be useful to review and merge this to close the issue.

@hadley hadley merged commit 59cbe63 into tidyverse:master Feb 10, 2018

3 checks passed

codecov/patch 100% of diff hit (target 77.05%)
Details
codecov/project 77.25% (+0.19%) compared to 714063c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@krlmlr krlmlr deleted the krlmlr:b-#89-inorder-na branch Feb 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment