New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of geom and stat params #1293

Closed
hadley opened this Issue Aug 26, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@hadley
Member

hadley commented Aug 26, 2015

Would be nice to have consistent way of discovering parameters so that layer can warn early if you have parameters that don't exist in the geom/stat.

Probably the easiest way would be to provide a character vector that lists the names of the parameters. This will require some manual book-keeping, but you should notice quickly during testing if you've forgotten to add a param.

Then should be able to eliminate use of ... in many of the individual methods. (Will still need it in the default compute_panel() because it passes onto compute_group()

@hadley hadley closed this in 7481d48 Aug 27, 2015

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.