-
Notifications
You must be signed in to change notification settings - Fork 2.1k
breaking change: alpha now impacts the line of stat_ based geoms. #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
A solve-it-all solution would be to have two different |
yes, please either revert or two different alpha parameters. This change broke many of my graphs... |
Thanks! |
I'm sorry for those who suffered with the change I proposed 😭 |
+1 for separate parameters for |
To answer requests from @dhimmel and others who need lines representing densities with alpha,
|
@antoine-lizee thanks for the workaround. I had to add |
This has changed following #1371, and I think (personally) that this is the wrong decision.
Pros: it's slightly more 'natural' to have alpha impacting both the line and fill (?)
Cons: the line texture is modified by the alpha parameter in a way that is irreversible, and thus you need a different geom for the common use case (to me) of having a solid line with a transparent filling.
Here is an example:
I would vote for reverting this behavior, as I'm pretty sure it's breaking more graphing code now than it would if reverted for 2.1.
The downside of the old behavior is that you need to change the color directly if you want something lighter.
The text was updated successfully, but these errors were encountered: