Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geom_violin quantile lines respond to alpha #1714

Closed
mnbram opened this issue Aug 16, 2016 · 2 comments
Closed

geom_violin quantile lines respond to alpha #1714

mnbram opened this issue Aug 16, 2016 · 2 comments
Labels
bug
Milestone

Comments

@mnbram
Copy link
Contributor

@mnbram mnbram commented Aug 16, 2016

The lines drawn by draw_quantiles in geom_violin are affected by the alpha parameter, so they cannot be included along with a transparent fill. Maybe there is a reason, but it seems to me that they should behave like any other lines.

Simple example:

ggplot(mtcars, aes(factor(cyl), mpg)) +
  geom_violin(draw_quantiles = 0.5, alpha = 0)
@mnbram
Copy link
Contributor Author

@mnbram mnbram commented Aug 22, 2016

I have a one line fix for this, but as it changes default behavior and I'm not exactly an expert software developer, I'm hesitant to submit it as a pull request. Should I do so anyway?

@thomasp85
Copy link
Member

@thomasp85 thomasp85 commented Aug 23, 2016

No harm in trying - we'll guide you through any quirks

@hadley hadley closed this Sep 23, 2016
@hadley hadley added this to the v2.2.0 milestone Sep 23, 2016
@hadley hadley added bug ready labels Sep 23, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants