Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
theme_void() does not remove grids #2079
Comments
basille
referenced
this issue
in wilkelab/cowplot
Mar 20, 2017
Closed
plot_grid and theme_update(panel.grid.major) #63
has2k1
added a commit
to has2k1/ggplot2
that referenced
this issue
Mar 20, 2017
|
|
has2k1 |
977e051
|
karawoo
added bug themes
labels
Jun 12, 2017
has2k1
added a commit
to has2k1/ggplot2
that referenced
this issue
Jul 3, 2017
|
|
has2k1 |
6dd2836
|
has2k1
added a commit
to has2k1/ggplot2
that referenced
this issue
Jul 14, 2017
|
|
has2k1 |
0c02a27
|
This was referenced Jul 17, 2017
has2k1
added a commit
to has2k1/ggplot2
that referenced
this issue
Aug 1, 2017
|
|
has2k1 |
a4184d5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
basille commentedMar 20, 2017
When using a custom grid,
theme_voiddoes not remove it. Here is a simple example illustrating it:Given that
theme_voidis supposed to be a completely empty theme, I thinktheme_voidshould redefine all elements toelement_blank(), includingpanel.grid.majorandpanel.grid.minor, and probably others (I believe it is somehow related to #2058, in the sense thattheme_voidshould redefine more elements than it currently does).