Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggsave: partial argument match of 'file' to 'filename' #2355

Closed
jennybc opened this issue Dec 1, 2017 · 3 comments · Fixed by #2364
Closed

ggsave: partial argument match of 'file' to 'filename' #2355

jennybc opened this issue Dec 1, 2017 · 3 comments · Fixed by #2364
Labels
bug an unexpected problem or unintended behavior good first issue ❤️ good issue for first-time contributors help wanted ❤️ we'd love your help!

Comments

@jennybc
Copy link
Member

jennybc commented Dec 1, 2017

I have all the warnPartialMatch* options set to TRUE in my .Rprofile. Every time I use ggsave() I get this warning. I took at look at plot_dev() and couldn't quickly determine if file (vs filename) is necessary for some devices? But for png() at least, it would be nice if this line was dev(filename = filename, width = dim[1], height = dim[2], ...).

library(ggplot2)

options(warnPartialMatchArgs = TRUE)

p <- ggplot(iris, aes(x = Petal.Length, y = Sepal.Width)) + geom_point()

ggsave("iris.png", p)
#> Saving 7 x 5 in image
#> Warning in grDevices::png(..., res = dpi, units = "in"): partial argument
#> match of 'file' to 'filename'

Created on 2017-12-01 by the reprex package (v0.1.1.9000).

@wch
Copy link
Member

wch commented Dec 8, 2017

This has been bugging me too. It is weird that some devices take file but others take filename.

@jzadra
Copy link

jzadra commented Feb 7, 2018

This still seems to be around.

@hadley hadley added good first issue ❤️ good issue for first-time contributors help wanted ❤️ we'd love your help! bug an unexpected problem or unintended behavior labels Apr 26, 2018
@lock
Copy link

lock bot commented Oct 23, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior good first issue ❤️ good issue for first-time contributors help wanted ❤️ we'd love your help!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants