/ggplot2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coord_trans() causes geom_hline() to draw incomplete lines #2812

Closed
mafed opened this Issue Aug 8, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mafed @clauswilke @hadley
@mafed

mafed commented Aug 8, 2018

geom_hline draws incomplete lines when used together with coord_trans, regardless of their respective order of addition.

mydf <- data.frame(x = 0L:20,
                   y = -10:10)
ggplot(data = mydf, aes(x, y)) + 
  geom_point() + 
  coord_trans(x = "log1p") +
  geom_hline(yintercept = c(-10, 10))

image

@mafed mafed changed the title from `coord_trans` causes `geom_hline` to draw incomplete lines to coord_trans causes geom_hline to draw incomplete lines Aug 8, 2018

@mafed mafed changed the title from coord_trans causes geom_hline to draw incomplete lines to coord_trans() causes geom_hline() to draw incomplete lines Aug 8, 2018

@clauswilke

This comment has been minimized.

Sign in to view
Member

clauswilke commented Aug 8, 2018

Duplicate of #2149?

clauswilke added a commit to clauswilke/ggplot2 that referenced this issue Aug 10, 2018

@clauswilke
update news. closes tidyverse#2149, tidyverse#2812
747c64a

@clauswilke clauswilke referenced this issue Aug 10, 2018

Merged

Fix back-transformation of ranges in coords #2821

@hadley hadley closed this Aug 10, 2018

clauswilke added a commit to clauswilke/ggplot2 that referenced this issue Aug 10, 2018

@clauswilke
update news. closes tidyverse#2149, tidyverse#2812
8516172

clauswilke added a commit to clauswilke/ggplot2 that referenced this issue Aug 11, 2018

@clauswilke
update news. closes tidyverse#2149, tidyverse#2812
ac38517
@mafed

This comment has been minimized.

Sign in to view

mafed commented Aug 13, 2018 •
edited

Thanks @clauswilke, look forward to your fix.
I noticed a duplicate issue but opened it anyway because the problem is still not fixed.

@clauswilke clauswilke referenced this issue Aug 17, 2018

Merged

Fix back-transformation of ranges in coords, without API cleanup #2832

clauswilke added a commit to clauswilke/ggplot2 that referenced this issue Aug 17, 2018

@clauswilke
update news. closes tidyverse#2149, tidyverse#2812
b6c0cbc

clauswilke added a commit to clauswilke/ggplot2 that referenced this issue Aug 22, 2018

@clauswilke
update news. closes tidyverse#2149, tidyverse#2812
02f11e8

clauswilke added a commit to clauswilke/ggplot2 that referenced this issue Aug 23, 2018

@clauswilke
update news. closes tidyverse#2149, tidyverse#2812
26cf887

clauswilke added a commit that referenced this issue Aug 23, 2018

@clauswilke
Fix back-transformation of ranges in coords, without API cleanup (#2832) 
* rename range() function of coord to backtransform_range()

* update news. closes #2149, #2812

* add range backtransformation function. closes #2820.

* fix typo in coord code

* add backtransform_range() to coord_map

* update summarise_layout to use backtransform_range() instead of range().

* Update coord documentation

* undo API cleanup

* update documentation

* rebase

* fix remaining issue from rebase
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
01155ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment