Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we compact facet grid specs? #2986

Closed
lionel- opened this issue Nov 9, 2018 · 2 comments
Closed

Should we compact facet grid specs? #2986

lionel- opened this issue Nov 9, 2018 · 2 comments

Comments

@lionel-
Copy link
Member

@lionel- lionel- commented Nov 9, 2018

This would make it easier to program with facets.

From https://stackoverflow.com/questions/53218152/ggplot2-facet-grid-with-conditional-facets-and-tidy-evaluation

plot_iris <- function(df_in, facet_var = NULL){
  ggplot(df_in) +
    geom_point(aes(Sepal.Length, Sepal.Width)) +
    facet_grid(vars(!!enquo(facet_var)), vars(idx))
}
@hadley
Copy link
Member

@hadley hadley commented Nov 9, 2018

That would be consistent with tidyverse/design#24

@lock
Copy link

@lock lock bot commented Oct 8, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants