Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geom_ribbon() now errors when ymin and ymax aesthetics are set rather than mapped #3318

Closed
paleolimbot opened this issue May 8, 2019 · 4 comments
Milestone

Comments

@paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented May 8, 2019

This was identified in the revdep checks (#3303), as it breaks a plot in bayesAB. This error was introduced on purpose (#3235). It's worth noting that the behaviour of layers when all the required aesthetics are set and not mapped is undefined and not consistent between geometries. See #3303 (comment) , #3235 (comment) , and #3303 (comment) .

library(ggplot2)
ggplot() + 
  geom_ribbon(x = 1:5, ymin = 0, ymax = 1:5, data = data.frame(1:5)) +
  geom_blank(aes(x = 1:5, y = 1:5))
#> Error: Either ymin or ymax must be given as an aesthetic.

Whereas in 3.1.1:

library(ggplot2)
ggplot() + 
  geom_ribbon(x = 1:5, ymin = 0, ymax = 1:5, data = data.frame(1:5)) +
  geom_blank(aes(x = 1:5, y = 1:5))

@clauswilke
Copy link
Member

@clauswilke clauswilke commented May 9, 2019

Per @thomasp85 (#3303 (comment)), we should contact the bayesAB authors to fix their code.

@paleolimbot Could you do that?

@paleolimbot
Copy link
Member Author

@paleolimbot paleolimbot commented May 9, 2019

@clauswilke
Copy link
Member

@clauswilke clauswilke commented May 9, 2019

Thanks!

@clauswilke clauswilke closed this May 9, 2019
stefan-m-lenz added a commit to stefan-m-lenz/BoltzmannMachinesRPlots that referenced this issue Sep 8, 2019
@lock
Copy link

@lock lock bot commented Nov 5, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants