Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export guide_axis() and consider improvements #3322

Closed
hadley opened this issue May 9, 2019 · 12 comments
Closed

Export guide_axis() and consider improvements #3322

hadley opened this issue May 9, 2019 · 12 comments
Assignees
Labels
feature a feature request or enhancement guides 📏 wip work in progress

Comments

@hadley
Copy link
Member

hadley commented May 9, 2019

Currently we have no equivalent to guide_legend() for axes (there is an non-exported guide_axis() but it draws the axes rather than describing their parameters). We should have an exported guide object to make it possible to have new types of axes.

The build in guide_axes() also needs to gain better tools for handling long labels:

  • Should haveangle parameter which handles all related theme settings
  • Should optionally trim overlapping labels by starting and either end and bisecting inwards (cf check.overlap = TRUE in grid.text()
  • Should be able to draw multiple lines of labels, alternating the position to avoid overlaps

And generally look at what vega-lite does for other ideas of useful parameters.

@paleolimbot
Copy link
Member

paleolimbot commented May 14, 2019

I spent about a day and a half on this, and wanted to leave a few things here for when I pick it back up again. So far I've:

  • Refactored guide_axis() to draw_axis(), since that's what the current version actually does (creates a grob)
  • Created a guide_axis() implementation that mimics guide_legend() and changed draw_axis() to create a guide, train it, then draw it.
  • Rewrote the grob creation code so that it might be easier to add features to (in a way that doesn't cause any dopplegangers to change)

https://github.com/paleolimbot/ggplot2/blob/0267a0aa48863b119f8288f95eac6fe87d89d95f/R/guides-axis.r#L125-L256

I still have to (provided all agree this is a good idea)

  • Refactor scale and guide code to treat position guides like other guides so they can be specified within scale_x_*(), scale_y_*(), sec_axis(), and guides()
  • Refactor Coord code to use guides the guides specified in scale_x_*(), scale_y_*(), sec_axis(), and guides() instead of using draw_axis()
  • Collect input on what (if any) improvements should go in guide_axis(), or if they should go in some other guide function (guide_axis_fancy(), or the like)

For reference, the vega-lite axis label documentation, which includes an option in inward-align labels on the end.

@clauswilke

This comment has been minimized.

@hadley

This comment has been minimized.

@clauswilke

This comment has been minimized.

@hadley

This comment has been minimized.

@paleolimbot
Copy link
Member

paleolimbot commented May 24, 2019

I've gotten this to work two ways now, and I would be grateful for some opinions on how best to go about things moving forward.

Getting guide specifications from the position Scales to Coord$render_axis_(h|v)() is not trivial. Both versions I have working use the Layout to coordinate panel guides, which (like the other guides) are resolved and trained at draw time (i.e., ggplot_gtable()). The Coord is responsible for generating a set of guides that it will receive in Coord$render_axis_(h|v)(), much like it does with panel_params.

I've gotten to versions to work (i.e., pass CMD check with no visual changes), one of which "injects" the panel guides into panel_params$guides in Layout$render() ( master...paleolimbot:issue-3322-guide-axis-panel-params ), and the other of which adds a panel_guides argument to Coord$render_axis_(h|v)() and Facet$draw_panels() ( master...paleolimbot:issue-3322-guide-axis-layout ). The first one I think is way better since it doesn't result in breaking any extensions of Facets or Coords.

It might be possible to avoid any changes outside CoordCartesian (as well as some other guide code) if the guides were generated at build time, but then they wouldn't have access to the same things that the other guides do (layers, default mapping, global guides list).

@paleolimbot
Copy link
Member

paleolimbot commented May 24, 2019

I suppose I'm curious whether having the Layout coordinate panel guides is appropriate, whether the internal changes in the other guide code that was required to make this work are likely to have effects in other places, and whether or not it would be more prudent to clean up the guide code first (#3329).

paleolimbot added a commit that referenced this issue Jun 18, 2019
, part of #3322)

* remove assumption that the panel_params contain any particular element in any coord code, update structure of panel_params in CoordCartesian to use scale syntax in preparation for updated guides

* move scale_range to coord_sf(), since it is no longer used in coord_cartesian()

* Update scales documentation, tidy styling of Scales methods

* finish tidy styling of scale-.r

* small modifications to scales such that ViewScales can be applied generically to all scales

* move view scale construction outside coord-cartesian.R

* move view scale to separate file

* move all view scale code to scale-view.r, rename constructors to view_scale_*

* Better documentation of ViewScale objects

* make view_scale_secondary() return a ViewScale subclass
@paleolimbot
Copy link
Member

paleolimbot commented Jun 26, 2019

I think this is the best place for my current thoughts on design, although if @hadley @thomasp85 and/or @clauswilke can think of a more appropriate place to discuss, let me know! These are my current thoughts in how to get user information about the position guides and get it to where the guides are drawn:

User-facing guide code

  • Guides that represent one scale should use the current infrastructure for specifying guides (i.e., scale_(x|y)_*(guide = ...) / guides((x|y) = ...)). The only difference from other guide code is that I think the default should be waiver() in the scale functions so that the coordinate system can pick the default guide.

  • Guides that represent more than one scale (e.g., guide_grid()) should be specified in the coord_*() constructor. This is already (sort of) the case for the guide_graticule() in coord_sf(), and I don't see any reason that we need to add any arguments to other coords at this time, since there really isn't any reason to cutomize the guide_grid() that can't already happen in the theme settings. Other panel guides are currently possible as layers (like annotation_logticks() or ggspatial::annotation_scale())...the only difference is that layers do not have access to the theme at draw time.

Internal guide code

  • Currently, guides are resolved, trained, exposed to the layers (to draw the glyphs), and turned into grobs at draw time (i.e., in ggplot_gtable()). I don't see any reason that this can't be the case for position guides as well.

  • Currently, all guides have exactly one position defined by the theme(). This should remain the case for the current guide code, but for position guides I think that guides should have a vector of positions so that code like guide_graticule(position = c("left", "bottom", "foreground")) and guide_axis(position = c("left", "right")) is possible.

  • Currently, all guides are trained with one scale and one scale only. This won't work for all position guides, which I think should be trained using a list of scales (just like that passed to Stat$compute_*()). This implies a different training process for position guides, which I think is necessary anyway. From much experimentation trying to get position scales/guides to survive the existing guide code, I think that new training code should be written, and eventually the rest of the guides should switch to using it. Because position guides are going to need separate training code, I think it makes sense to write them as ggproto() objects whose state is internal (like scales).

Guide <- ggproto(
  "Guide", NULL,
  title = NULL,
  position = NULL,
  aesthetics = NULL,
  data = NULL,
  
  # I *think* this is enough information to perform the merge externally
  # NULL = never merge
  hash = function(self, scale) {
    # title <- scale$make_title(guide$title %|W|% scale$name %|W|% labels[[output]])
    # digest::digest(list(title, self$aesthetics, class(self), scale$get_labels())
    NULL
  },
  
  # encompases the current guide_train() and guide_geom()
  train = function(scales, layers, default_mapping) {
    # self$data <- ...
    # invisible(self$data)
    stop("Not implemented", call. = FALSE)
  },
  
  # position is because guides may look different depending on where they are
  # drawn. It is the caller's responsibility to put the grob in the
  # right place
  draw = function(self, theme, coord, position = NULL) {
    stop("Not implemented", call. = FALSE)
  }
)
  • Position guides should be resolved by the coordinate system and added to the panel_params as the guides element. This happens at draw time rather than build time, so it needs to be a new method in the Coord. They should go in the panel_params because they are already everywhere the guides are drawn (i.e., no new arguments!). We are also narrowing in to a point where there is a common structure to panel_params for all coords ($x and $y will soon be scale-like objects always, and $guides will be a list() of trained guides).
CoordCartesian <- ggproto(
  ...,
  setup_panel_guides = function(self, panel_params, guides, params) {
    scales <- panel_params[c("x", "y")]
    panel_guides <- list(
      x = guides$x %||% scales$x$guide %|W|% guide_axis(),
      y = guides$y %||% scales$y$guide %|W% guide_axis(),
      guide_grid(aesthetics = c("x", "y"), position = "foreground")
    )
    # resolve guide objects
    panel_guides <- lapply(panel_guides, validate_guide)
    # set default positions and aesthetics if they aren't set
    panel_guides <- lapply(panel_guides, ...)
    # add to panel_params
    panel_params$guides <- lapply(panel_guides, validate_guide)
    
    panel_params
  }
)
  • The Coord should also train the guides, but maybe not in the same place as resolving them. This mostly reflects different information requirements and helps keep all the functions short. Also, this means that coordinate systems that don't participate in the new system are left alone.
CoordCartesian <- ggproto(
  ...,
  train_panel_guides = function(self, panel_params, layers, default_mapping, params) {
    scales <- panel_params[c("x", "y")]
    if (is.null(panel_params$guides)) {
      return()
    }
    
    scales <- panel_params[c("x", "y")]
    lapply(panel_params$guides, function(guide) guide$train(scales, ))
    invisible(panel_params)
  }
)
  • The Layout will have to pass the guides, layers, and default_mapping to these methods. These are all available in ggplot_gtable(), which calls the method.
Layout <- ggproto(
  ...,
  setup_panel_guides = function(self, guides, layers, default_mapping) {
    self$panel_params <- lapply(
      self$panel_params,
      self$coord$setup_panel_guides,
      guides, 
      self$coord_params
    )
    
    self$panel_params <- lapply(
      self$panel_params,
      self$coord$train_panel_guides,
      layers, 
      default_mapping,
      self$coord_params
    )
    
    invisible()
  }
)
  • Then, the Coord has access to trained guides in its panel_params, which already get passed to Coord$render_*() by the Facet.
CoordCartesian <- ggproto(
  ...,
  render_bg = function(panel_params, theme) {
    guides <- get_guides(panel_params, "background")
    ...
  },
  render_fg = function(panel_params, theme) {
    guides <- get_guides(panel_params, "foreground")
    ...
  },
  render_axis_h = function(panel_params, theme) {
    guides_top <- get_guides(panel_params, "top")
    guides_bottom <- get_guides(panel_params, "bottom")
    list(top = ..., bottom = ...)
  },
  render_axis_v = function(panel_params, theme) {
    guides_left <- get_guides(panel_params, "left")
    guides_right <- get_guides(panel_params, "right")
    list(left = ..., right = ...)
  }
)

Thoughts? Suggestions? Modifications?

@clauswilke
Copy link
Member

clauswilke commented Jun 26, 2019

Does this in any way address the problem that geoms (or stats?) may need access to the trained scales (#3116)? Could they now get that access through the coord, at draw time?

@paleolimbot
Copy link
Member

paleolimbot commented Jun 27, 2019

The coord would still only deal with position scales. I've since figured out a way to get access to the non position scales...I forgot to update the issue.

@paleolimbot
Copy link
Member

paleolimbot commented Jun 30, 2019

Reflecting on this over the weekend, I now feel that I should avoid ggproto() and guide_grid(), focusing only on x and y guides. They will get trained slightly differently but I think they can use S3 until all the guides are switched over.

ThomasKnecht added a commit to ThomasKnecht/ggplot2 that referenced this issue Oct 14, 2019
commit b049018
Merge: e1846bc ccf0ee5
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 12:29:23 2019 +0200

    Resolve conflict

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

    # Conflicts:
    #	R/position-nudgestack.R

commit e1846bc
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:58:47 2019 +0200

    Add package spezifications

commit 5de0449
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:53:06 2019 +0200

    Add package spezifications

commit d9ec752
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit e0368b0
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 325456a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 3210061
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 739ac7c
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 662a5da
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 598b786
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit 90d1257
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 415811c
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:44:37 2019 +0200

    Add news

commit 6e4398c
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit b61211d
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 369a34b
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit e4e7ee0
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 4d66dad
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 1b61750
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit 65e72fb
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit e5d61b5
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit 8848fd9
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit 28640d5
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit 59bc2a0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 71d567b
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 3a1c71f
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit f26bb90
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 3ba06ab
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit fbf28dc
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 5270a9d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit 32d2203
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit fc6ba5a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit b1bb9d1
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit d1c7ad8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit 621730d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 0750e55
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit ce942ac
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit 86dfea0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit ccf0ee5
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:58:47 2019 +0200

    Add package spezifications

commit 831d569
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:53:06 2019 +0200

    Add package spezifications

commit af4abb5
Merge: 0a89016 0ff81cb
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Wed Oct 2 16:37:11 2019 +0200

    Resolve conflict

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

    # Conflicts:
    #	R/position-nudgestack.R

commit 0a89016
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:44:37 2019 +0200

    Add news

commit 083454a
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 9cdcf6a
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 7d23e89
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 99eab52
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 5fa6969
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 8642839
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit f891dbc
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit a960ca8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 5b89b32
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 37f1bd6
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit e392ac8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit d443b80
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit d967b8e
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit b1c8b1a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 55602af
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 9f6aa7d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit 1b7c4c0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 6d76c3a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit f67ae70
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit 14fd33d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit 0ff81cb
Merge: 7214587 10fa001
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Wed Oct 2 13:46:28 2019 +0200

    Merge remote-tracking branch 'upstream/master' into Add_position_nudgestack

commit 10fa001
Author: Thomas Lin Pedersen <thomasp85@gmail.com>
Date:   Tue Oct 1 11:12:59 2019 +0200

    Removing direction constraint from geoms (tidyverse#3506)

commit 88c5bde
Author: Mine Cetinkaya-Rundel <cetinkaya.mine@gmail.com>
Date:   Tue Oct 1 09:32:08 2019 +0100

    Minor updates to data docs (tidyverse#3545)

commit 7214587
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:44:37 2019 +0200

    Add news

commit 28ba9bf
Merge: daeb34e e688944
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:32:12 2019 +0200

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

commit daeb34e
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit e688944
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 9a45cc8
Author: Thomas Lin Pedersen <thomasp85@gmail.com>
Date:   Tue Oct 1 09:03:07 2019 +0200

    scale_binned (tidyverse#3096)

commit 02a038e
Merge: 88f4a63 bde6844
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:01:10 2019 +0200

    Resolve conflict

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

    # Conflicts:
    #	R/position-nudgestack.R

commit 88f4a63
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit 752e476
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit 5271987
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 771918d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit da1e7be
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:37 2019 +0200

    Delete packages from example

commit a1573b3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 59d2b6e
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:50 2019 +0200

    Update vdiffr version

commit 0e80c8a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit 31cc104
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit dc6b78d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit d35ea70
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit 87c00fa
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit f587fb8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:48 2019 +0200

    Add description of position_nudgestack

commit 327a6cd
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:13 2019 +0200

    Add position_nudgestack into description

commit c97d54d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 7fbc0f7
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit 9d894a8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 56e9b3b
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 4535be6
Author: Mara Alexeev <39673697+MaraAlexeev@users.noreply.github.com>
Date:   Tue Sep 3 08:26:07 2019 -0400

    Clarify documentation in mpg: very minor (tidyverse#3515)

    * add helpful explanation of mpg$drv

commit c8fa99f
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit a290bb3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit bde6844
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit 0ee259c
Author: bernie gray <bfgray3@users.noreply.github.com>
Date:   Mon Sep 30 06:54:57 2019 -0400

    default formula argument to NULL in geom_smooth() (tidyverse#3307)

commit fa000f7
Author: Dewey Dunnington <dewey@fishandwhistle.net>
Date:   Sun Sep 29 18:26:36 2019 -0300

    Make position guides customizable (tidyverse#3398, closes tidyverse#3322)

    * Position guides can now be customized using the new `guide_axis()`, which can be passed to position `scale_*()` functions or via `guides()`. The new axis guide (`guide_axis()`) comes with arguments `check.overlap` (automatic removal of overlapping labels), `angle` (easy rotation of axis labels), and `n.dodge` (dodge labels into multiple rows/columns)

    * `CoordCartesian` gets new methods to resolve/train the new position guides

commit 696fe9d
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit b027238
Merge: 10b5e24 c32f856
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 16:38:27 2019 +0200

    Merge branch 'Add_position_nudgestack' of https://github.com/TeddyLeeJones/ggplot2 into Add_position_nudgestack

commit 10b5e24
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 4fb6996
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:37 2019 +0200

    Delete packages from example

commit 823c686
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit e6df407
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:50 2019 +0200

    Update vdiffr version

commit be91893
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit f44e504
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 3713420
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit 9291957
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit ef5aef7
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 42c0fa3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:48 2019 +0200

    Add description of position_nudgestack

commit 548f313
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:13 2019 +0200

    Add position_nudgestack into description

commit 7bb930c
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 9bd40d6
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit c5022d3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 8572437
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 3d61c3a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit 2782c9d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit c32f856
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit d5c58da
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:37 2019 +0200

    Delete packages from example

commit 015b2e3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 2484f71
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:50 2019 +0200

    Update vdiffr version

commit e2c1fb6
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit a681f59
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 02f6be4
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit def4755
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit c1729d1
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 5ebe5d4
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:48 2019 +0200

    Add description of position_nudgestack

commit 99b4b5e
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:13 2019 +0200

    Add position_nudgestack into description

commit 971b110
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit e5e91ea
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit fedef93
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit bcc75a3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 23e3241
Author: Mara Alexeev <39673697+MaraAlexeev@users.noreply.github.com>
Date:   Tue Sep 3 08:26:07 2019 -0400

    Clarify documentation in mpg: very minor (tidyverse#3515)

    * add helpful explanation of mpg$drv

commit 01d7db0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit a486906
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack
ThomasKnecht added a commit to ThomasKnecht/ggplot2 that referenced this issue Oct 14, 2019
commit b049018
Merge: e1846bc ccf0ee5
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 12:29:23 2019 +0200

    Resolve conflict

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

    # Conflicts:
    #	R/position-nudgestack.R

commit e1846bc
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:58:47 2019 +0200

    Add package spezifications

commit 5de0449
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:53:06 2019 +0200

    Add package spezifications

commit d9ec752
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit e0368b0
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 325456a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 3210061
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 739ac7c
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 662a5da
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 598b786
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit 90d1257
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 415811c
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:44:37 2019 +0200

    Add news

commit 6e4398c
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit b61211d
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 369a34b
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit e4e7ee0
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 4d66dad
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 1b61750
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit 65e72fb
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit e5d61b5
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit 8848fd9
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit 28640d5
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit 59bc2a0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 71d567b
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 3a1c71f
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit f26bb90
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 3ba06ab
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit fbf28dc
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 5270a9d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit 32d2203
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit fc6ba5a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit b1bb9d1
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit d1c7ad8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit 621730d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 0750e55
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit ce942ac
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit 86dfea0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit ccf0ee5
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:58:47 2019 +0200

    Add package spezifications

commit 831d569
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:53:06 2019 +0200

    Add package spezifications

commit af4abb5
Merge: 0a89016 0ff81cb
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Wed Oct 2 16:37:11 2019 +0200

    Resolve conflict

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

    # Conflicts:
    #	R/position-nudgestack.R

commit 0a89016
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:44:37 2019 +0200

    Add news

commit 083454a
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 9cdcf6a
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 7d23e89
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 99eab52
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 5fa6969
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 8642839
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit f891dbc
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit a960ca8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 5b89b32
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 37f1bd6
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit e392ac8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit d443b80
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit d967b8e
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit b1c8b1a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 55602af
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 9f6aa7d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit 1b7c4c0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 6d76c3a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit f67ae70
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit 14fd33d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit 0ff81cb
Merge: 7214587 10fa001
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Wed Oct 2 13:46:28 2019 +0200

    Merge remote-tracking branch 'upstream/master' into Add_position_nudgestack

commit 10fa001
Author: Thomas Lin Pedersen <thomasp85@gmail.com>
Date:   Tue Oct 1 11:12:59 2019 +0200

    Removing direction constraint from geoms (tidyverse#3506)

commit 88c5bde
Author: Mine Cetinkaya-Rundel <cetinkaya.mine@gmail.com>
Date:   Tue Oct 1 09:32:08 2019 +0100

    Minor updates to data docs (tidyverse#3545)

commit 7214587
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:44:37 2019 +0200

    Add news

commit 28ba9bf
Merge: daeb34e e688944
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:32:12 2019 +0200

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

commit daeb34e
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit e688944
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 9a45cc8
Author: Thomas Lin Pedersen <thomasp85@gmail.com>
Date:   Tue Oct 1 09:03:07 2019 +0200

    scale_binned (tidyverse#3096)

commit 02a038e
Merge: 88f4a63 bde6844
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:01:10 2019 +0200

    Resolve conflict

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

    # Conflicts:
    #	R/position-nudgestack.R

commit 88f4a63
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit 752e476
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit 5271987
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 771918d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit da1e7be
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:37 2019 +0200

    Delete packages from example

commit a1573b3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 59d2b6e
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:50 2019 +0200

    Update vdiffr version

commit 0e80c8a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit 31cc104
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit dc6b78d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit d35ea70
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit 87c00fa
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit f587fb8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:48 2019 +0200

    Add description of position_nudgestack

commit 327a6cd
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:13 2019 +0200

    Add position_nudgestack into description

commit c97d54d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 7fbc0f7
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit 9d894a8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 56e9b3b
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 4535be6
Author: Mara Alexeev <39673697+MaraAlexeev@users.noreply.github.com>
Date:   Tue Sep 3 08:26:07 2019 -0400

    Clarify documentation in mpg: very minor (tidyverse#3515)

    * add helpful explanation of mpg$drv

commit c8fa99f
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit a290bb3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit bde6844
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit 0ee259c
Author: bernie gray <bfgray3@users.noreply.github.com>
Date:   Mon Sep 30 06:54:57 2019 -0400

    default formula argument to NULL in geom_smooth() (tidyverse#3307)

commit fa000f7
Author: Dewey Dunnington <dewey@fishandwhistle.net>
Date:   Sun Sep 29 18:26:36 2019 -0300

    Make position guides customizable (tidyverse#3398, closes tidyverse#3322)

    * Position guides can now be customized using the new `guide_axis()`, which can be passed to position `scale_*()` functions or via `guides()`. The new axis guide (`guide_axis()`) comes with arguments `check.overlap` (automatic removal of overlapping labels), `angle` (easy rotation of axis labels), and `n.dodge` (dodge labels into multiple rows/columns)

    * `CoordCartesian` gets new methods to resolve/train the new position guides

commit 696fe9d
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit b027238
Merge: 10b5e24 c32f856
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 16:38:27 2019 +0200

    Merge branch 'Add_position_nudgestack' of https://github.com/TeddyLeeJones/ggplot2 into Add_position_nudgestack

commit 10b5e24
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 4fb6996
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:37 2019 +0200

    Delete packages from example

commit 823c686
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit e6df407
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:50 2019 +0200

    Update vdiffr version

commit be91893
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit f44e504
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 3713420
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit 9291957
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit ef5aef7
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 42c0fa3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:48 2019 +0200

    Add description of position_nudgestack

commit 548f313
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:13 2019 +0200

    Add position_nudgestack into description

commit 7bb930c
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 9bd40d6
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit c5022d3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 8572437
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 3d61c3a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit 2782c9d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit c32f856
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit d5c58da
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:37 2019 +0200

    Delete packages from example

commit 015b2e3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 2484f71
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:50 2019 +0200

    Update vdiffr version

commit e2c1fb6
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit a681f59
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 02f6be4
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit def4755
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit c1729d1
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 5ebe5d4
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:48 2019 +0200

    Add description of position_nudgestack

commit 99b4b5e
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:13 2019 +0200

    Add position_nudgestack into description

commit 971b110
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit e5e91ea
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit fedef93
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit bcc75a3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 23e3241
Author: Mara Alexeev <39673697+MaraAlexeev@users.noreply.github.com>
Date:   Tue Sep 3 08:26:07 2019 -0400

    Clarify documentation in mpg: very minor (tidyverse#3515)

    * add helpful explanation of mpg$drv

commit 01d7db0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit a486906
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack
@lock
Copy link

lock bot commented Mar 27, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement guides 📏 wip work in progress
Projects
None yet
Development

No branches or pull requests

3 participants