Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release ggplot2 3.5.0 #5588

Closed
20 of 23 tasks
thomasp85 opened this issue Dec 15, 2023 · 2 comments · Fixed by #5592
Closed
20 of 23 tasks

Release ggplot2 3.5.0 #5588

thomasp85 opened this issue Dec 15, 2023 · 2 comments · Fixed by #5592
Milestone

Comments

@thomasp85
Copy link
Member

thomasp85 commented Dec 15, 2023

Pre-release maintenance:

Create a release PR:

  • usethis::pr_init("rc/3.5.0")
  • usethis::use_version('minor')
  • usethis::pr_push()
  • Comment that the PR closes this issue

Run release checks:

  • Wait for CI checks to pass
  • devtools::check(remote = TRUE, manual = TRUE)
  • devtools::check_win_devel()
  • revdepcheck::cloud_check()
  • Update cran-comments.md

Submit to CRAN:

  • devtools::submit_cran()
  • Approve email
  • Accepted 🎉

Finish up:

  • usethis::pr_view()
  • usethis::use_github_release()
  • Merge PR (Don't squash merge!)
  • usethis::pr_finish()
  • usethis::use_dev_version(push = TRUE)
@teunbrand
Copy link
Collaborator

As feedback on the checklist:

It seems easier to do usethis::pr_init("rc/3.5.0") first, then do everything in the 1st block.
Also the cran-comments.md step should come after the revdepcheck results are in, I think.

@thomasp85
Copy link
Member Author

+1 to the placement of cran-comment update. That's an oversight

The reason for the current setup with some tasks before veering off into a new branch is that it makes it much easier to merge the two branches together afterwards because new news items will be clearly separated from the one in the RC

This was referenced Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants