New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stat_function to compute function on data not aesthetic scale #1011

Merged
merged 4 commits into from Jul 23, 2015

Conversation

Projects
None yet
2 participants
@BrianDiggs
Contributor

BrianDiggs commented Sep 17, 2014

stat_function currently computes the function with the transformed
(not original data) values. This causes the values to be wrong if
a different scale, other than continuous, is used.

See http://stackoverflow.com/q/9382032/892313 for an example
of this.

stat_function to compute function on data not aesthetic scale
stat_function currently computes the function with the transformed
(not original data) values. This causes the values to be wrong if
a different scale, other than continuous, is used.

See http://stackoverflow.com/q/9382032/892313 for an exmple
of this.
@@ -134,3 +134,26 @@ test_that("stat-density2d", {
expect_true(max(ret$y) > 35)

})

context("stat-function")

This comment has been minimized.

@hadley

hadley Jun 11, 2015

Member

Would you mind putting this in a new file?

@hadley

This comment has been minimized.

Member

hadley commented Jun 11, 2015

Could you please also

  • add a bullet to NEWS
  • merge/rebase
@BrianDiggs

This comment has been minimized.

Contributor

BrianDiggs commented Jun 18, 2015

I'll work on it this weekend.

@BrianDiggs

This comment has been minimized.

Contributor

BrianDiggs commented Jun 25, 2015

Comments addressed.

@hadley hadley merged commit cda1229 into tidyverse:master Jul 23, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Jul 23, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment