Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stat_function to compute function on data not aesthetic scale #1011

Merged
merged 4 commits into from
Jul 23, 2015

Conversation

BrianDiggs
Copy link
Contributor

stat_function currently computes the function with the transformed
(not original data) values. This causes the values to be wrong if
a different scale, other than continuous, is used.

See http://stackoverflow.com/q/9382032/892313 for an example
of this.

stat_function currently computes the function with the transformed
(not original data) values. This causes the values to be wrong if
a different scale, other than continuous, is used.

See http://stackoverflow.com/q/9382032/892313 for an exmple
of this.
@@ -134,3 +134,26 @@ test_that("stat-density2d", {
expect_true(max(ret$y) > 35)

})

context("stat-function")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind putting this in a new file?

@hadley
Copy link
Member

hadley commented Jun 11, 2015

Could you please also

  • add a bullet to NEWS
  • merge/rebase

@BrianDiggs
Copy link
Contributor Author

I'll work on it this weekend.

@BrianDiggs
Copy link
Contributor Author

Comments addressed.

@hadley hadley merged commit cda1229 into tidyverse:master Jul 23, 2015
@hadley
Copy link
Member

hadley commented Jul 23, 2015

Thanks!

@lock
Copy link

lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants