Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tick marks from theme_minimal #1084

Merged
merged 1 commit into from Jun 18, 2015
Merged

Remove tick marks from theme_minimal #1084

merged 1 commit into from Jun 18, 2015

Conversation

@tomschloss
Copy link
Contributor

@tomschloss tomschloss commented Apr 13, 2015

A very minor change: I've removed tick marks from theme_minimal() as I think that is more in keeping with "minimalism". The black ticks seemed a little visually unnecessary.

Incidentally, removing black ticks it also aligns minimal to the default plotly theme.

All good if you don't like the idea.

qplot(data = mtcars, x = mpg, y = wt) + theme_minimal() 

Before:
before

After:
after

Tom

I've removed tick marks from theme_minimal as I think that is more in keeping with the theme name. The black ticks seemed a little visually unnecessary.
@hadley
Copy link
Member

@hadley hadley commented Jun 11, 2015

I think the numbers now look a bit far away from the axis. Could you tweak that too please?

Also needs a merge/rebase and a bullet point in NEWS

@hadley hadley merged commit f3a3a41 into tidyverse:master Jun 18, 2015
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@hadley
Copy link
Member

@hadley hadley commented Jun 18, 2015

Merged by hand - thanks for the patch!

@lock
Copy link

@lock lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants