Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new function geom_curve #1088

Merged
merged 3 commits into from Jun 12, 2015
Merged

Added new function geom_curve #1088

merged 3 commits into from Jun 12, 2015

Conversation

veraanadi
Copy link
Contributor

No description provided.

#' \Sexpr[results=rd,stage=build]{ggplot2:::rd_aesthetics("geom", "curve")}
#'
#' @inheritParams geom_point
#' @param curvature see curveGrob
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @inheritParams grid::curveGrob would be more useful here

@hadley
Copy link
Member

hadley commented Jun 11, 2015

Overall idea looks good.

Also needs a merge/rebase and a bullet point in NEWS

@veraanadi
Copy link
Contributor Author

I hope I understood your suggestions correctly. I tried to include everything and did a merge/rebase and updated NEWS. If something still needs to be done, just let me know.

@@ -50,6 +53,8 @@ ggplot2 1.0.1.9000
* Improved documentation for `aes()` and many geoms and scales. I've tried
to reduce the use of `...` so that you can see all the documentation in one
place rather than having to navigate through multiple pages.
* Added new function geom_curve to add curved lines to plot (similar to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something went wrong here - the bullet is duplicated

@veraanadi
Copy link
Contributor Author

Thanks for your patience. I hope, this time everything is OK.

@hadley
Copy link
Member

hadley commented Jun 12, 2015

Looks good - thanks!

hadley added a commit that referenced this pull request Jun 12, 2015
Added new function geom_curve
@hadley hadley merged commit c582922 into tidyverse:master Jun 12, 2015
@lock
Copy link

lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants