Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished removing qplot #1123

Merged
merged 3 commits into from Jun 12, 2015
Merged

Finished removing qplot #1123

merged 3 commits into from Jun 12, 2015

Conversation

@hrbrmstr
Copy link
Contributor

@hrbrmstr hrbrmstr commented Jun 12, 2015

The only places qplot remains are in:

  • quick-plot.r
  • translate-qplot-base.r
  • translate-qplot-ggplot.r
  • translate-qplot-gpl.r
  • translate-qplot-lattice.r
@hrbrmstr
Copy link
Contributor Author

@hrbrmstr hrbrmstr commented Jun 12, 2015

I also tried to clean up spacing around = when those were noticed and there were some errors in the examples that I also fixed.

@hadley
Copy link
Member

@hadley hadley commented Jun 12, 2015

Thanks! This looks great. Would you mind merging/rebasing and adding a bullet to NEWS?

@hrbrmstr
Copy link
Contributor Author

@hrbrmstr hrbrmstr commented Jun 12, 2015

will do.

On Fri, Jun 12, 2015 at 8:53 AM, Hadley Wickham notifications@github.com
wrote:

Thanks! This looks great. Would you mind merging/rebasing and adding a
bullet to NEWS?


Reply to this email directly or view it on GitHub
#1123 (comment).

@hadley
Copy link
Member

@hadley hadley commented Jun 12, 2015

Actually I'll merge myself since I need to make some other changes to the examples.

@hrbrmstr
Copy link
Contributor Author

@hrbrmstr hrbrmstr commented Jun 12, 2015

Roger that. If possible, please keep in the change I made to the US map
plot (added an albers projection). Every new R user wanting to make a US
map uses that ggplot documentation example and produces horrible mercator
US maps from it. At least now future US maps from new R folk might use a
proper projection ;-)

On Fri, Jun 12, 2015 at 3:19 PM, Hadley Wickham notifications@github.com
wrote:

Actually I'll merge myself since I need to make some other changes to the
examples.


Reply to this email directly or view it on GitHub
#1123 (comment).

@hadley
Copy link
Member

@hadley hadley commented Jun 12, 2015

Will do! Also any interest in this? andysouth/rworldmap#4

@hadley hadley merged commit bbfc5be into tidyverse:master Jun 12, 2015
@lock
Copy link

@lock lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants