Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stroke option to geom_point. #1133

Merged
merged 1 commit into from Jun 18, 2015
Merged

Add stroke option to geom_point. #1133

merged 1 commit into from Jun 18, 2015

Conversation

@Symaxion
Copy link
Contributor

@Symaxion Symaxion commented Jun 16, 2015

This PR adds an aesthetic option stroke to geom_point that makes it possible to specify the stroke width of point shapes 21-25 (see #1085, I had to resubmit because you can't force push when an issue is closed).

@hadley
Copy link
Member

@hadley hadley commented Jun 18, 2015

Could you please:

  • re-document, so travis passes
  • add an example of usage to geom_point()

@Symaxion
Copy link
Contributor Author

@Symaxion Symaxion commented Jun 18, 2015

I've added a basic example and made sure all the checks pass without warnings now. Are there any other places where I need to update documentation as well?

hadley added a commit that referenced this issue Jun 18, 2015
Add stroke option to geom_point.
@hadley hadley merged commit 07f138e into tidyverse:master Jun 18, 2015
1 check passed
@hadley
Copy link
Member

@hadley hadley commented Jun 18, 2015

Thanks!

@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants