Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all found instances of partial matching #1134

Merged
merged 2 commits into from Jun 16, 2015

Conversation

@jimhester
Copy link
Member

@jimhester jimhester commented Jun 16, 2015

These were found by setting

options(warnPartialMatchAttr = TRUE,
    warnPartialMatchDollar = TRUE,
    warn = 2)

Using r-lib/testthat#269 with options("testthat.suppress" = NULL) and running
devtools::test() and vtest::vtest() until there were no more partial
match messages.

There may still be some instances in the code base, but I think this
finds the vast majority.

jimhester added 2 commits Jun 16, 2015
These were found by setting

options(warnPartialMatchAttr = TRUE,
    warnPartialMatchDollar = TRUE,
    warn = 2)

Using testthat#269 with `options("testthat.suppress" = NULL)` and running
`devtools::test()` and `vtest::vtest()` until there were no more partial
match messages.

There may still be some instances in the code base, but I think this
finds the vast majority.
hadley added a commit that referenced this issue Jun 16, 2015
Fix all found instances of partial matching
@hadley hadley merged commit 8520750 into tidyverse:master Jun 16, 2015
1 check was pending
@hadley
Copy link
Member

@hadley hadley commented Jun 16, 2015

Thanks!

@lock
Copy link

@lock lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants