Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access to direction argument of scales::brewer_pal #1139

Merged
merged 2 commits into from Jul 27, 2015

Conversation

@jiho
Copy link
Contributor

@jiho jiho commented Jun 18, 2015

Plus minor example and documentation fixes

+ minor example and documentation fixes
@jiho jiho force-pushed the jiho:feature/brewer_scale_direction branch from bf104b0 to 711ad7c Jun 18, 2015
@@ -1,3 +1,7 @@
* Add access to the new `direction` argument of `scales::brewer_pal` and

This comment has been minimized.

@hadley

hadley Jun 18, 2015
Member

Sorry I think I was unclear bfore, this should be the first bullet under the version heading

This comment has been minimized.

@jiho

jiho Jun 18, 2015
Author Contributor

Oh, OK. I thought this is what I always did so I misunderstood your comment regarding this. I'll correct it.

BTW, do you prefer 1-commit pull requests (in which case I overwrite the changes each time and force push, so I guess line comments like this disappear) or many small commits are OK (in which case the "history" of the PR itself is kept but it gets messier when merged).

This comment has been minimized.

@hadley

hadley Jun 18, 2015
Member

Small commits is fine - if it gets too messy I'll ask you to flatten.

@hadley hadley merged commit 851154f into tidyverse:master Jul 27, 2015
@hadley
Copy link
Member

@hadley hadley commented Jul 27, 2015

Thanks!

@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants