New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`bins` argument to `stat_bin` #1158

Merged
merged 5 commits into from Jul 29, 2015

Conversation

Projects
None yet
2 participants
@tmshn
Contributor

tmshn commented Jul 6, 2015

As discussed in issue #102 , it will be nicer if geom_histogram can handle the number of bins, not the width.
To achieve it, I added new argument bins to stat_bin, which denotes number of bins.

This is less prior to breaks or binwidth, so with these arguments, bins will not work.

Added new parameter `bins` to `stat_bin`, which denotes number of bin…
…s. This is less prior to `breaks` or `binwidth`.
@hadley

This comment has been minimized.

Member

hadley commented Jul 27, 2015

Could you please merge/rebase and add a bullet to NEWS?

tmshn added some commits Jul 29, 2015

Merge branch 'master' of https://github.com/hadley/ggplot2 into featu…
…re/stat_bin-num

Conflicts:
	R/geom-bar-histogram.r
	R/stat-bin.r
	man/geom_histogram.Rd
	man/stat_bin.Rd
@tmshn

This comment has been minimized.

Contributor

tmshn commented Jul 29, 2015

Done.
Sorry for so many commits :(

@hadley hadley merged commit 308a4f4 into tidyverse:master Jul 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Jul 29, 2015

Thanks!

@tmshn tmshn deleted the tmshn:feature/stat_bin-num branch Jul 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment