Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates theme-defaults.r (#1555) #1557

Merged
merged 3 commits into from Feb 24, 2016
Merged

Updates theme-defaults.r (#1555) #1557

merged 3 commits into from Feb 24, 2016

Conversation

@Katiedaisey
Copy link
Contributor

@Katiedaisey Katiedaisey commented Feb 24, 2016

addresses issue #1555 where some elements added under certain themes inherit "element_blank" and cannot be updated, e.g.

ggplot(mtcars, aes(wt, mpg)) + geom_point() + theme_classic() + theme(panel.grid.major.y = element_line(colour = "pink", size = 4))

update explicitly declares parent element as necessary and children elements as element_blank

Katiedaisey added 2 commits Feb 24, 2016
addresses issue #1555 - elements added in new theme inherit "element_blank"
@@ -33,6 +33,8 @@

## Bug fixes

* All elements should now inherit correctly for all themes except theme_void(). (@Katiedaisey, #1555)

This comment has been minimized.

@hadley

hadley Feb 24, 2016
Member

Would you mind alphabetising this under theme_void()

@Katiedaisey
Copy link
Contributor Author

@Katiedaisey Katiedaisey commented Feb 24, 2016

Should be fixed

hadley added a commit that referenced this pull request Feb 24, 2016
@hadley hadley merged commit b0f10d0 into tidyverse:master Feb 24, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley
Copy link
Member

@hadley hadley commented Feb 24, 2016

Thanks - much appreciated :).

This was referenced Mar 10, 2016
thomasp85 added a commit that referenced this pull request Sep 21, 2016
Fixes #1555, #1557, #1565, and #1567

* Add inherit.blank argument to element constructors

* Look for inherit.blank when combining

* Set inherit.blank = TRUE automatically when theme is complete
@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants