Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in geom-violin.r when quantiles requested but data have no range. #1687

Merged
merged 4 commits into from Aug 5, 2016

Conversation

@DanRuderman
Copy link
Contributor

@DanRuderman DanRuderman commented Jul 29, 2016

No description provided.

@hadley
Copy link
Member

@hadley hadley commented Aug 2, 2016

Could you please also add a bullet point to news, and a small unit test (using the simplest possible dataset and layer_data())

@DanRuderman
Copy link
Contributor Author

@DanRuderman DanRuderman commented Aug 3, 2016

Do you mean a unit test that is

  • particular to this bug (ensuring that it doesn't error out anymore and that the layer_data() is correct), or
  • one that is more general (e.g. creates a ggplot() including geom_violin() draw_quantiles for some relatively simple data and ensures that the layer_data() are correct)?

Or perhaps something else?

@hadley
Copy link
Member

@hadley hadley commented Aug 3, 2016

Particular to this bug.

@DanRuderman
Copy link
Contributor Author

@DanRuderman DanRuderman commented Aug 3, 2016

Since my fix is in draw_group() there is no impact on layer_data(), but there is on layer_grob(). Test that instead?

@hadley
Copy link
Member

@hadley hadley commented Aug 3, 2016

Yes, although testing grobs is hard.

@DanRuderman
Copy link
Contributor Author

@DanRuderman DanRuderman commented Aug 3, 2016

How about evaluating the grob just to make sure it no longer errors out and testing the contents of the layer_data() for validity?

@hadley
Copy link
Member

@hadley hadley commented Aug 3, 2016

Sounds good

@DanRuderman
Copy link
Contributor Author

@DanRuderman DanRuderman commented Aug 3, 2016

All done.

@hadley hadley merged commit 84c203a into tidyverse:master Aug 5, 2016
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 91859da...987baee
Details
codecov/project 67.02% (+0.00%) compared to 91859da
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley
Copy link
Member

@hadley hadley commented Aug 5, 2016

Thanks!

@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants