Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Move ggplot2 logo to man/figures/ #2155

Merged
merged 2 commits into from Jun 13, 2017

Conversation

Projects
None yet
2 participants
Collaborator

karawoo commented Jun 13, 2017

Fixes #2083.

@karawoo karawoo Move ggplot2 logo to man/figures/
05dec0a

karawoo requested a review from hadley Jun 13, 2017

Owner

hadley commented Jun 13, 2017

Can you please also tweak the knitr options so the README images go in that directory too? (And you'll need to delete the old README-example-1.png)

@karawoo karawoo Update knitr options to put README images in man/figures/
2d40e33
@hadley

hadley approved these changes Jun 13, 2017

Owner

hadley commented Jun 13, 2017

(I've approved this so you can go ahead and merge it yourself. I usually use squash and merge to eliminate unimportant intermediate commits and keep a cleaner history. If someone has put a lot of effort into making the commit history clean, you can do a regular merge).

@karawoo karawoo merged commit f84e315 into tidyverse:master Jun 13, 2017

4 checks passed

codecov/patch Coverage not affected when comparing eedaa81...2d40e33
Details
codecov/project 74.97% remains the same compared to eedaa81
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

karawoo deleted the karawoo:move-logo branch Jun 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment