use fortify.grouped_df() instead of ggplot.grouped_df() #2623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
approved these changes
May 17, 2018
hadley
approved these changes
May 17, 2018
|
Thanks! |
This was referenced Jun 9, 2018
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2578
This PR removes
ggplot.data.frame()andggplot.grouped_df()so that alldatapassed toggplot()getfortify()ed. Then,fortify.grouped_df()can take care of fortifyinggrouped_dfs.Note that one possible downside of this PR is this change of behaviour of
ggplot():data.framefortify.data.frame()returns the originaldata.frameas is, but some objects inheriting fromdata.framemight be fortified if it has its own method offortify().But, I bet this will be rarely a problem; I cannot imagine the design where both the fortified version and unfortified version of the class are needed. If the method of
fortify()is defined, it is probably supposed to be used.