Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CODE_OF_CONDUCT.md to the main directory #2973

Merged
merged 4 commits into from Nov 2, 2018

Conversation

@yutannihilation
Copy link
Member

commented Nov 1, 2018

Fixes #2979

The link to Code of Conduct in GOVERNANCE.md seems broken.

Copy link
Member

left a comment

LGTM. Unless for some reason, we want to move the code of conduct into the main directory?

@yutannihilation

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2018

Thanks, the main directory sounds the right place, considering similar kind of files e.g. ISSUE_TEMPLATE.md are also there.

I thought GitHub recognizes CODE_OF_CONDUCT.md only when it is under .github/, but it's not:

Add the CODE_OF_CONDUCT.md file to the root, docs/, or .github/ folder.
(https://help.github.com/articles/adding-a-code-of-conduct-to-your-project/)

@yutannihilation yutannihilation changed the title Fix an URL in GOVERNANCE.md Move CODE_OF_CONDUCT.md to the main directory Nov 2, 2018
@hadley hadley merged commit 05dfaea into tidyverse:master Nov 2, 2018
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 765f4de...6abea99
Details
codecov/project 77.8% remains the same compared to 765f4de
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Copy link
Member

commented Nov 2, 2018

Thanks!

@yutannihilation yutannihilation deleted the yutannihilation:patch-2 branch Nov 2, 2018
@lock

This comment has been minimized.

Copy link

commented May 1, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators May 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.