Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better descent #2996

Merged
merged 14 commits into from Nov 13, 2018
Merged

Better descent #2996

merged 14 commits into from Nov 13, 2018

Conversation

@thomasp85
Copy link
Member

@thomasp85 thomasp85 commented Nov 13, 2018

Fix #2687

As per discussion in #2687, using descentDetail() will get the graphic parameters from the viewport and not from the grob itself. This PR implements the suggestion from @pmur002 in the thread by using grobDescent() instead.

@thomasp85 thomasp85 requested review from clauswilke and hadley Nov 13, 2018
@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Nov 13, 2018

df <- data.frame(x = 1)
ggplot(df, aes(x, x)) + geom_point() +
  ggtitle("gjpjQ") +
  theme(plot.title = element_text(size = 100))

image

@thomasp85 thomasp85 mentioned this pull request Nov 13, 2018
hadley
hadley approved these changes Nov 13, 2018
@thomasp85 thomasp85 merged commit b4b725e into tidyverse:master Nov 13, 2018
1 of 2 checks passed
@clauswilke clauswilke mentioned this pull request May 6, 2019
@lock
Copy link

@lock lock bot commented May 12, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators May 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants