Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the definition of scale_color_continuous #3079

Merged
merged 4 commits into from
Jan 21, 2019
Merged

Updated the definition of scale_color_continuous #3079

merged 4 commits into from
Jan 21, 2019

Conversation

hlendway
Copy link
Contributor

Updated the definition of scale_color_continuous to be scale_colour_continous instead of gradient so that it functions as the documentation states. Fixes issue #3053

Updated the definition of scale_color_continuous to be scale_colour_c…
3f1cb48 
…ontinous instead of gradient so that it functions as the documentation states.
@clauswilke
Copy link
Member

clauswilke commented Jan 19, 2019 •
edited
Loading

Please add a news item to this file: https://github.com/tidyverse/ggplot2/blob/master/NEWS.md

@hadley
Copy link
Member

hadley commented Jan 19, 2019

@clauswilke I have a github snippet for news bullets:

Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@karawoo
Copy link
Member

karawoo commented Jan 19, 2019

@hadley might be worth updating that to NEWS.md, I think we've had to correct people editing the NEWS file which I don't think we're using anymore?

@hlendway
Copy link
Contributor Author

I will add to NEWS.md today.

clauswilke
clauswilke requested changes Jan 20, 2019
View reviewed changes
NEWS.md Outdated
@@ -1,4 +1,7 @@
# ggplot2 3.1.0.9000

* `scale_color_continuous()` now points at `scale_colour_continuos()` so that it
will handle `type` = "viridis" as the documentation states (@hlendway, #3079).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closing backtick should be after "viridis", as in `type = "viridis"`.

@clauswilke
Copy link
Member

This is good now. Unfortunately there is a merge conflict with the latest version of ggplot2, due to the many changes that have happened in NEWS.md. You'll have to merge with upstream to resolve this. Here is a rough explanation of how this works: https://help.github.com/articles/syncing-a-fork/ You'll have to do this in your development branch instead of master, though. (In step 4, instead of checking out master, you check out the branch you're working on. Everything else is the same.)

Synced with master and merged NEWS.md
9e0ccf0 
Merge remote-tracking branch 'upstream/master' into hjl_tidyverse_dev_day

# Conflicts:
#	NEWS.md
@hlendway
Copy link
Contributor Author

Thanks @clauswilke for the instructions, hopefully that worked OK, please let me know if there are additional things to do. I really appreciate the guidance through the process!

@clauswilke clauswilke merged commit da6ea8d into tidyverse:master Jan 21, 2019
@clauswilke clauswilke mentioned this pull request Jan 21, 2019
Closed
@clauswilke
Copy link
Member

Thanks!

@tidyverse tidyverse deleted a comment from BangerNPoo Jan 28, 2019
@hlendway hlendway deleted the hjl_tidyverse_dev_day branch February 19, 2019 01:21
@lock
Copy link

lock bot commented Aug 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Aug 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clauswilke clauswilke clauswilke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlendway @clauswilke @hadley @karawoo