Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the definition of scale_color_continuous #3079

Merged
merged 4 commits into from Jan 21, 2019

Conversation

@hlendway
Copy link
Contributor

@hlendway hlendway commented Jan 19, 2019

Updated the definition of scale_color_continuous to be scale_colour_continous instead of gradient so that it functions as the documentation states. Fixes issue #3053

…ontinous instead of gradient so that it functions as the documentation states.
@clauswilke
Copy link
Member

@clauswilke clauswilke commented Jan 19, 2019

Please add a news item to this file: https://github.com/tidyverse/ggplot2/blob/master/NEWS.md

@hadley
Copy link
Member

@hadley hadley commented Jan 19, 2019

@clauswilke I have a github snippet for news bullets:

Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@karawoo
Copy link
Member

@karawoo karawoo commented Jan 19, 2019

@hadley might be worth updating that to NEWS.md, I think we've had to correct people editing the NEWS file which I don't think we're using anymore?

@hlendway
Copy link
Contributor Author

@hlendway hlendway commented Jan 20, 2019

I will add to NEWS.md today.

NEWS.md Outdated
@@ -1,4 +1,7 @@
# ggplot2 3.1.0.9000

* `scale_color_continuous()` now points at `scale_colour_continuos()` so that it
will handle `type` = "viridis" as the documentation states (@hlendway, #3079).
Copy link
Member

@clauswilke clauswilke Jan 20, 2019

The closing backtick should be after "viridis", as in `type = "viridis"`.

@clauswilke
Copy link
Member

@clauswilke clauswilke commented Jan 21, 2019

This is good now. Unfortunately there is a merge conflict with the latest version of ggplot2, due to the many changes that have happened in NEWS.md. You'll have to merge with upstream to resolve this. Here is a rough explanation of how this works: https://help.github.com/articles/syncing-a-fork/ You'll have to do this in your development branch instead of master, though. (In step 4, instead of checking out master, you check out the branch you're working on. Everything else is the same.)

Merge remote-tracking branch 'upstream/master' into hjl_tidyverse_dev_day

# Conflicts:
#	NEWS.md
@hlendway
Copy link
Contributor Author

@hlendway hlendway commented Jan 21, 2019

Thanks @clauswilke for the instructions, hopefully that worked OK, please let me know if there are additional things to do. I really appreciate the guidance through the process!

@clauswilke clauswilke merged commit da6ea8d into tidyverse:master Jan 21, 2019
4 checks passed
@clauswilke
Copy link
Member

@clauswilke clauswilke commented Jan 21, 2019

Thanks!

@tidyverse tidyverse deleted a comment from BangerNPoo Jan 28, 2019
@hlendway hlendway deleted the hjl_tidyverse_dev_day branch Feb 19, 2019
@lock
Copy link

@lock lock bot commented Aug 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Aug 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants