Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grid errors when quantiles falls outside of violin #3254

Merged
merged 3 commits into from Apr 24, 2019

Conversation

@thomasp85
Copy link
Member

@thomasp85 thomasp85 commented Apr 23, 2019

Fixes #2885

In certain instances quantiles will have NA coordinates and the computed aesthetics will not match the number of lines to draw, leading to grid errors

@thomasp85 thomasp85 added this to the ggplot2 3.2.0 milestone Apr 23, 2019
@thomasp85 thomasp85 requested a review from yutannihilation Apr 23, 2019
Copy link
Member

@yutannihilation yutannihilation left a comment

Generally, seems good.

NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
R/geom-violin.r Show resolved Hide resolved
Co-Authored-By: thomasp85 <thomasp85@gmail.com>
@thomasp85 thomasp85 merged commit 8724c8e into tidyverse:master Apr 24, 2019
4 checks passed
@lock
Copy link

@lock lock bot commented Oct 21, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants