Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw axis line when length(breaks) == 0 #3257

Merged
merged 2 commits into from Apr 23, 2019

Conversation

@thomasp85
Copy link
Member

@thomasp85 thomasp85 commented Apr 23, 2019

Fixes #2983

Prior to this, guide_axis() would return a zeroGrob when no break position where provided. This meant that axis lines were not drawn in these situations. This fix changes the behaviour so that axis lines always will be drawn (if allowed by the theme)

@hadley I've asked you to review as the old behaviour may have been deliberate

@thomasp85 thomasp85 added this to the ggplot2 3.2.0 milestone Apr 23, 2019
@thomasp85 thomasp85 requested a review from hadley Apr 23, 2019
hadley
hadley approved these changes Apr 23, 2019
Copy link
Member

@hadley hadley left a comment

This seems unlikely to have been deliberate.

@thomasp85 thomasp85 merged commit f79712f into tidyverse:master Apr 23, 2019
4 checks passed
@lock
Copy link

@lock lock bot commented Oct 20, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants