Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescale sec.axis correctly for CoordPolar #3278

Merged
merged 2 commits into from Apr 30, 2019

Conversation

@thomasp85
Copy link
Member

@thomasp85 thomasp85 commented Apr 29, 2019

Fixes #3185

This PR adds correct scaling of the secondary axis when used with CoordPolar() as proposed by @linzi-sg

@thomasp85 thomasp85 added this to the ggplot2 3.2.0 milestone Apr 29, 2019
@thomasp85 thomasp85 requested a review from yutannihilation Apr 29, 2019
@thomasp85 thomasp85 requested a review from clauswilke Apr 30, 2019
@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Apr 30, 2019

@clauswilke if you have time, can you review this?

Copy link
Member

@clauswilke clauswilke left a comment

LGTM

@thomasp85 thomasp85 merged commit 981215e into tidyverse:master Apr 30, 2019
1 of 2 checks passed
@lock
Copy link

@lock lock bot commented Oct 27, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants