Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not change order of positive and negative values in PositionStack #3471

Merged
merged 2 commits into from Aug 9, 2019

Conversation

@thomasp85
Copy link
Member

@thomasp85 thomasp85 commented Aug 5, 2019

fixes #3390

@karawoo I have checked that this fix does not cause regressions in #1552. Basically what this does is avoid positive and negative y-values to get reordered, not fiddle with the group-based reordering

@thomasp85 thomasp85 added this to the ggplot2 3.2.1 milestone Aug 5, 2019
@thomasp85 thomasp85 requested a review from clauswilke Aug 5, 2019
@@ -195,7 +195,7 @@ PositionStack <- ggproto("PositionStack", Position,
)
}

rbind(neg, pos)
rbind(neg, pos)[match(seq_len(nrow(data)), c(which(negative), which(!negative))),]
Copy link
Member

@clauswilke clauswilke Aug 5, 2019

I don't see immediately that this is always correct. Can there be problems with NAs? Or will NAs never reach this point?

Copy link
Member Author

@thomasp85 thomasp85 Aug 5, 2019

An NA value in ymax is pretty nonsensical and would also have broken the previous code. I can put in some guarding if you’d like nonetheless

Copy link
Member

@clauswilke clauswilke Aug 5, 2019

No strong opinion either way. Just make sure to look into why the CI builds fail.

Copy link
Member Author

@thomasp85 thomasp85 Aug 5, 2019

The failures are due to the downstream changes in sf, which have been fixed in master but not yet merged into the v3.2.1-rc branch

karawoo
karawoo approved these changes Aug 5, 2019
Copy link
Member

@karawoo karawoo left a comment

LGTM, I'll close #3401

@lock
Copy link

@lock lock bot commented Feb 5, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants