Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep missingness of qplot() to label axis nicely #3473

Conversation

@yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Aug 6, 2019

Closes #3467.

In #2936, I added .ignore_empty = "all" to rlang::enquos() in aes() and in qplot() to remove missing x and y automatically. But, as qplot() generates labels directly from the input, missingness should be kept there. This PR reverts #2936's changes about qplot().

library(ggplot2)

set.seed(2009)
x <- rnorm(100)
qplot(x, geom = "histogram")
#> `stat_bin()` using `bins = 30`. Pick better value with `binwidth`.

Created on 2019-08-06 by the reprex package (v0.3.0)

@yutannihilation yutannihilation added this to the ggplot2 3.2.1 milestone Aug 6, 2019
@thomasp85 thomasp85 merged commit d4b3328 into tidyverse:v3.2.1-rc Aug 9, 2019
0 of 2 checks passed
Loading
@yutannihilation yutannihilation deleted the hotfix/issue-3467-qplot-y-labels branch Aug 9, 2019
@lock
Copy link

@lock lock bot commented Feb 5, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

Loading

@lock lock bot locked and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants