Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing direction constraint from geoms #3506

Merged
merged 52 commits into from Oct 1, 2019
Merged

Conversation

thomasp85
Copy link
Member

@thomasp85 thomasp85 commented Aug 28, 2019

Some geoms have directionality constraint, e.g. geom_histogram() that requires binning along the x-axis. The gospel has been to use coord_flip() if one wanted binning along the y-axis, but that comes with a set of limitations. Further the constraint seems arbitrary from a user perspective.

This PR explores the possibility of making relevant geoms work in either direction. Hopefully this can completely remove the need for ggstance.

Geoms, stats, and positions under consideration

  • geom_bar
  • geom_histogram
  • geom_violin
  • geom_col
  • geom_linerange()
  • geom_pointrange()
  • geom_errorbar()
  • geom_crossbar()
  • geom_boxplot()
  • geom_density()
  • geom_area()
  • geom_ribbon()
  • geom_line()
  • geom_smooth()
  • stat_bin()
  • stat_boxplot()
  • stat_count()
  • stat_density()
  • stat_ydensity() (consider renaming this for clarity)
  • stat_summary()
  • position_dodge()
  • position_dodge2()
  • position_fill()
  • position_stack()
  • position_jitterdodge()

Please add to this list if anything comes up. @clauswilke when we have settled on this it would be great if ggridges could be updated to reflect this as well

@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Aug 28, 2019

One thing to consider is how to deal with ambiguity in directional geoms. geom_col() for instance could be used in situations where the data can be interpreted in either direction. Should we add a direction argument that default to NA (i.e. we try to guess) but can be used to overwrite guessing

@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Aug 28, 2019

This should also deprecate geom_errorbarh

@clauswilke
Copy link
Member

@clauswilke clauswilke commented Aug 28, 2019

Could you describe your overarching strategy/expected API? In an ideal world, the stat (e.g. density) shouldn't have to know about x and y at all and just produce two output columns, one for the dependent and one for the independent variable. These could then be mapped to x and y however one wants. However, I haven't been able to make this possible in the existing ggplot2 stat and geom framework. So I assume you're doing something else.

Also, are there any parts of the logic that could be encapsulated into reusable functions or maybe into a ggproto superclass, so that not that much code duplication is required?

@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Aug 28, 2019

This is very much WIP at the moment as I’m exploring what is possible. Don’t expect the current state of the code to prevail.

The overarching strategy is to let the stats (and geoms) sniff out the wanted orientation from the mapping of the aesthetics. Many are quite easy such as histograms where you just look at whether x or y is mapped. Others need inspection of the data types mapped to x and y to figure out which one is discrete. Others still are fully ambiguous and we’ll need to figure out what to do there.

The plan and hope is that it should “just work” by mapping the variables to the right aesthetics, but whether this is possible is open

@clauswilke
Copy link
Member

@clauswilke clauswilke commented Aug 29, 2019

Auto-detection + optional manual override should work fine.

@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Aug 29, 2019

yeah, that was my plan as well... don't know if we want manual override for all or just the ones where ambiguity exist though

@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Aug 29, 2019

@clauswilke can you remember why you created the GeomCol class? It seems identical to the GeomBar class it subclasses...

AFAIK, geom_col() should just be StatIdentity and GeomBar, right?

@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Aug 29, 2019

One annoying side effect of this is that many of these stats/geoms have to have their required_aes field removed as they can take two non-overlapping sets of aesthetics to work. Would be nice if this could somehow be specified so we don't loose the self-documenting feature of the field (along with the error handling)

@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Aug 29, 2019

One way to address the problem of removing required aesthetics will be to add another field to geoms and stats (required_aes_alt, or something) that will be checked and handled along with the primary field... What say you @hadley ?

@clauswilke
Copy link
Member

@clauswilke clauswilke commented Aug 29, 2019

I didn't create GeomCol, I'm just the last one who touched it. I looked at the code right now and compared it to GeomBar and I don't see any differences. Maybe they were different at some point and converged.

@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Aug 29, 2019

Oh yeah. It was @hrbrmstr. Got it mixed up

@hadley
Copy link
Member

@hadley hadley commented Aug 29, 2019

Maybe you could make all these Geoms inherit from (say) GeomFlippable and then it could provide custom required aesthetic logic?

I don't see an obvious way to update the documentation generation, ideally we'd special case something where it would generate "x or y".

Or maybe a better option would be to introduce some special sentinel value required_aes = c("x|y")?

@mjskay
Copy link
Contributor

@mjskay mjskay commented Aug 29, 2019

Can I offer some unsolicited thoughts after seeing this on Twitter? :) I recently implemented something similar in tidybayes (the multiple-orientations-one geom part, not the part that chooses orientation automatically --- I love the idea of having that sniffed out automatically and am planning to add it now too, with an API consistent with whatever is decided here).

I came to a similar solution as @thomasp85 : have a parameter like direction (I called mine orientation) and then write the code to use either x or y based columns depending on that parameter. I did do things a little differently from there: I created a somewhat hackish function define_orientation_variables that I can call at the top of any function that needs to interact with the data. This allowed me to rewrite my geoms very easily; code that looked like this:

draw_panel = function(self, data, panel_params, coord) {
  ...
  data$y = data$ymin + justification * data$height
  ...
}

Became:

draw_panel = function(self, data, panel_params, coord, orientation) {
  define_orientation_variables(orientation)
  ...
  data[[y]] = data[[ymin]] + justification * data[[height]]
  ...
}

Which saved me a bunch of switches and code duplication and other headaches when rewriting those geoms. Now I just write the geoms as if they are have a horizontal orientation in my mind and define_orientation_variables takes care of the vertical case. On the other hand, this is perhaps a very weird style of API that produces code that works for me internally in one package and might not be appropriate for a broadly-used API like ggplot, but I wonder if something similar in spirit could be used here to make building such geoms similarly straightforward.

A few other things:

  • I like the idea of having a parameter to control this explicitly with default value NA meaning "automatic", as @thomasp85 suggested. FWIW as a single data point about discoverability, that's the interface I had assumed it would take after hearing about it on Twitter but before seeing the code.
  • I think that "orientation" is a better word for this than "direction". "direction" connotes more... well, direction to me, like "up" or "down", not "horizontal" or "vertical", which I think of as orientations. This answer on English stack exchange seems to agree with my intuition. I think not using "direction" here would also be more consistent with the use of "direction" elsewhere in the ggplot API (e.g. the direction parameter in scale_colour_brewer controls the direction of the color mapping in the palette, not its orientation, which is meaningless).
  • +1 to @hadley's suggestion of a Geom to inherit from. Relatedly, it strikes me that detect_direction (or what have you) would also make more sense as a method instead of a function.

@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Aug 29, 2019

Thanks for chiming in @mjskay... Some quick thoughts:

  • I don't feel good about your define_orientation_variables() solution. It is way too magicking and I'll usually refrain from creating environment-changing side effects for the benefit of less typing. Some tooling around this is needed (maybe the current switch_position(), maybe something else), but it should not do funny stuff
  • orientation sounds good to me
  • I'm almost 100% certain that this cannot be abstracted away into a virtual Geom subclass that you can just subclass and everything will be fine. It might be doable with the Stat changes, but will require more effort than it is worth IMO

@hadley the "x|y" nomenclature sounds good to me, but will require some thought in how it is implemented. What would be really nice would be to define two separate sets of aesthetics that needs to be defined, e.g. x, ymin, and ymax or y, xmin, and max, instead of x or y, xmin or ymin, and xmax or ymax

@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Sep 18, 2019

Ok, last piece of the puzzle: stat_summary(). We have decided to rename the arguments from fun.ymin, fun.y, and fun.ymax to fun.min, fun, and fun.max. But, what should we expect the output of fun.data to be? Currently nothing gets enforced, but should we expect the function to output correctly named columns or should we flip it automatically (e.g. expect it to behave as it should unflipped)?

The easiest is to expect the function to output data with y, ymin, and ymax columns even in the case of flipped axes but will this be weird?

@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Sep 18, 2019

It was really a no-brainer as all of the supplied function returns data in x-orientation format so this is what we continue to support

@thomasp85 thomasp85 changed the title WIP: Removing direction constraint from geoms Removing direction constraint from geoms Sep 19, 2019
@thomasp85 thomasp85 requested review from clauswilke and hadley Sep 19, 2019
@thomasp85 thomasp85 marked this pull request as ready for review Sep 19, 2019
@hadley
Copy link
Member

@hadley hadley commented Sep 19, 2019

@thomasp85 can you give me a few pointers as to where to focus my effort?

@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Sep 19, 2019

The main logic lies in has_flipped_aes() so checking the assumptions in there would be first priority. Also, documentation of the feature and whether it is understandable

R/utilities.r Outdated Show resolved Hide resolved
R/utilities.r Show resolved Hide resolved
R/utilities.r Outdated Show resolved Hide resolved
R/utilities.r Outdated Show resolved Hide resolved
R/utilities.r Outdated Show resolved Hide resolved
R/utilities.r Outdated Show resolved Hide resolved
hadley
hadley approved these changes Sep 27, 2019
Copy link
Member

@hadley hadley left a comment

Two small documentation comments, otherwise it looks good to go.

R/utilities.r Outdated Show resolved Hide resolved
R/utilities.r Outdated Show resolved Hide resolved
@thomasp85
Copy link
Member Author

@thomasp85 thomasp85 commented Sep 27, 2019

Haven’t I provided examples for all options in the section ?

@thomasp85 thomasp85 merged commit 10fa001 into tidyverse:master Oct 1, 2019
2 of 4 checks passed
ThomasKnecht added a commit to ThomasKnecht/ggplot2 that referenced this issue Oct 14, 2019
commit b049018
Merge: e1846bc ccf0ee5
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 12:29:23 2019 +0200

    Resolve conflict

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

    # Conflicts:
    #	R/position-nudgestack.R

commit e1846bc
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:58:47 2019 +0200

    Add package spezifications

commit 5de0449
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:53:06 2019 +0200

    Add package spezifications

commit d9ec752
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit e0368b0
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 325456a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 3210061
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 739ac7c
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 662a5da
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 598b786
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit 90d1257
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 415811c
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:44:37 2019 +0200

    Add news

commit 6e4398c
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit b61211d
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 369a34b
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit e4e7ee0
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 4d66dad
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 1b61750
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit 65e72fb
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit e5d61b5
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit 8848fd9
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit 28640d5
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit 59bc2a0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 71d567b
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 3a1c71f
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit f26bb90
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 3ba06ab
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit fbf28dc
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 5270a9d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit 32d2203
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit fc6ba5a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit b1bb9d1
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit d1c7ad8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit 621730d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 0750e55
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit ce942ac
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit 86dfea0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit ccf0ee5
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:58:47 2019 +0200

    Add package spezifications

commit 831d569
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:53:06 2019 +0200

    Add package spezifications

commit af4abb5
Merge: 0a89016 0ff81cb
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Wed Oct 2 16:37:11 2019 +0200

    Resolve conflict

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

    # Conflicts:
    #	R/position-nudgestack.R

commit 0a89016
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:44:37 2019 +0200

    Add news

commit 083454a
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 9cdcf6a
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 7d23e89
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 99eab52
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 5fa6969
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 8642839
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit f891dbc
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit a960ca8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 5b89b32
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 37f1bd6
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit e392ac8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit d443b80
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit d967b8e
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit b1c8b1a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 55602af
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 9f6aa7d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit 1b7c4c0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 6d76c3a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit f67ae70
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit 14fd33d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit 0ff81cb
Merge: 7214587 10fa001
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Wed Oct 2 13:46:28 2019 +0200

    Merge remote-tracking branch 'upstream/master' into Add_position_nudgestack

commit 10fa001
Author: Thomas Lin Pedersen <thomasp85@gmail.com>
Date:   Tue Oct 1 11:12:59 2019 +0200

    Removing direction constraint from geoms (tidyverse#3506)

commit 88c5bde
Author: Mine Cetinkaya-Rundel <cetinkaya.mine@gmail.com>
Date:   Tue Oct 1 09:32:08 2019 +0100

    Minor updates to data docs (tidyverse#3545)

commit 7214587
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:44:37 2019 +0200

    Add news

commit 28ba9bf
Merge: daeb34e e688944
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:32:12 2019 +0200

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

commit daeb34e
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit e688944
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 9a45cc8
Author: Thomas Lin Pedersen <thomasp85@gmail.com>
Date:   Tue Oct 1 09:03:07 2019 +0200

    scale_binned (tidyverse#3096)

commit 02a038e
Merge: 88f4a63 bde6844
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:01:10 2019 +0200

    Resolve conflict

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

    # Conflicts:
    #	R/position-nudgestack.R

commit 88f4a63
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit 752e476
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit 5271987
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 771918d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit da1e7be
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:37 2019 +0200

    Delete packages from example

commit a1573b3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 59d2b6e
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:50 2019 +0200

    Update vdiffr version

commit 0e80c8a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit 31cc104
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit dc6b78d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit d35ea70
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit 87c00fa
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit f587fb8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:48 2019 +0200

    Add description of position_nudgestack

commit 327a6cd
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:13 2019 +0200

    Add position_nudgestack into description

commit c97d54d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 7fbc0f7
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit 9d894a8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 56e9b3b
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 4535be6
Author: Mara Alexeev <39673697+MaraAlexeev@users.noreply.github.com>
Date:   Tue Sep 3 08:26:07 2019 -0400

    Clarify documentation in mpg: very minor (tidyverse#3515)

    * add helpful explanation of mpg$drv

commit c8fa99f
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit a290bb3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit bde6844
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit 0ee259c
Author: bernie gray <bfgray3@users.noreply.github.com>
Date:   Mon Sep 30 06:54:57 2019 -0400

    default formula argument to NULL in geom_smooth() (tidyverse#3307)

commit fa000f7
Author: Dewey Dunnington <dewey@fishandwhistle.net>
Date:   Sun Sep 29 18:26:36 2019 -0300

    Make position guides customizable (tidyverse#3398, closes tidyverse#3322)

    * Position guides can now be customized using the new `guide_axis()`, which can be passed to position `scale_*()` functions or via `guides()`. The new axis guide (`guide_axis()`) comes with arguments `check.overlap` (automatic removal of overlapping labels), `angle` (easy rotation of axis labels), and `n.dodge` (dodge labels into multiple rows/columns)

    * `CoordCartesian` gets new methods to resolve/train the new position guides

commit 696fe9d
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit b027238
Merge: 10b5e24 c32f856
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 16:38:27 2019 +0200

    Merge branch 'Add_position_nudgestack' of https://github.com/TeddyLeeJones/ggplot2 into Add_position_nudgestack

commit 10b5e24
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 4fb6996
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:37 2019 +0200

    Delete packages from example

commit 823c686
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit e6df407
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:50 2019 +0200

    Update vdiffr version

commit be91893
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit f44e504
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 3713420
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit 9291957
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit ef5aef7
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 42c0fa3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:48 2019 +0200

    Add description of position_nudgestack

commit 548f313
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:13 2019 +0200

    Add position_nudgestack into description

commit 7bb930c
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 9bd40d6
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit c5022d3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 8572437
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 3d61c3a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit 2782c9d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit c32f856
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit d5c58da
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:37 2019 +0200

    Delete packages from example

commit 015b2e3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 2484f71
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:50 2019 +0200

    Update vdiffr version

commit e2c1fb6
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit a681f59
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 02f6be4
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit def4755
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit c1729d1
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 5ebe5d4
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:48 2019 +0200

    Add description of position_nudgestack

commit 99b4b5e
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:13 2019 +0200

    Add position_nudgestack into description

commit 971b110
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit e5e91ea
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit fedef93
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit bcc75a3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 23e3241
Author: Mara Alexeev <39673697+MaraAlexeev@users.noreply.github.com>
Date:   Tue Sep 3 08:26:07 2019 -0400

    Clarify documentation in mpg: very minor (tidyverse#3515)

    * add helpful explanation of mpg$drv

commit 01d7db0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit a486906
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack
ThomasKnecht added a commit to ThomasKnecht/ggplot2 that referenced this issue Oct 14, 2019
commit b049018
Merge: e1846bc ccf0ee5
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 12:29:23 2019 +0200

    Resolve conflict

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

    # Conflicts:
    #	R/position-nudgestack.R

commit e1846bc
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:58:47 2019 +0200

    Add package spezifications

commit 5de0449
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:53:06 2019 +0200

    Add package spezifications

commit d9ec752
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit e0368b0
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 325456a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 3210061
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 739ac7c
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 662a5da
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 598b786
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit 90d1257
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 415811c
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:44:37 2019 +0200

    Add news

commit 6e4398c
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit b61211d
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 369a34b
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit e4e7ee0
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 4d66dad
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 1b61750
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit 65e72fb
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit e5d61b5
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit 8848fd9
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit 28640d5
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit 59bc2a0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 71d567b
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 3a1c71f
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit f26bb90
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 3ba06ab
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit fbf28dc
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 5270a9d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit 32d2203
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit fc6ba5a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit b1bb9d1
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit d1c7ad8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit 621730d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 0750e55
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit ce942ac
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit 86dfea0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit ccf0ee5
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:58:47 2019 +0200

    Add package spezifications

commit 831d569
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Oct 7 11:53:06 2019 +0200

    Add package spezifications

commit af4abb5
Merge: 0a89016 0ff81cb
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Wed Oct 2 16:37:11 2019 +0200

    Resolve conflict

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

    # Conflicts:
    #	R/position-nudgestack.R

commit 0a89016
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:44:37 2019 +0200

    Add news

commit 083454a
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 9cdcf6a
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 7d23e89
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 99eab52
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 5fa6969
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 8642839
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit f891dbc
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit a960ca8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 5b89b32
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 37f1bd6
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit e392ac8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit d443b80
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit d967b8e
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit b1c8b1a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 55602af
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 9f6aa7d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit 1b7c4c0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 6d76c3a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit f67ae70
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit 14fd33d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit 0ff81cb
Merge: 7214587 10fa001
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Wed Oct 2 13:46:28 2019 +0200

    Merge remote-tracking branch 'upstream/master' into Add_position_nudgestack

commit 10fa001
Author: Thomas Lin Pedersen <thomasp85@gmail.com>
Date:   Tue Oct 1 11:12:59 2019 +0200

    Removing direction constraint from geoms (tidyverse#3506)

commit 88c5bde
Author: Mine Cetinkaya-Rundel <cetinkaya.mine@gmail.com>
Date:   Tue Oct 1 09:32:08 2019 +0100

    Minor updates to data docs (tidyverse#3545)

commit 7214587
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:44:37 2019 +0200

    Add news

commit 28ba9bf
Merge: daeb34e e688944
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:32:12 2019 +0200

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

commit daeb34e
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit e688944
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:20:41 2019 +0200

    Style file

commit 9a45cc8
Author: Thomas Lin Pedersen <thomasp85@gmail.com>
Date:   Tue Oct 1 09:03:07 2019 +0200

    scale_binned (tidyverse#3096)

commit 02a038e
Merge: 88f4a63 bde6844
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 09:01:10 2019 +0200

    Resolve conflict

    Merge branch 'Add_position_nudgestack' of https://github.com/ThomasKnecht/ggplot2 into Add_position_nudgestack

    # Conflicts:
    #	R/position-nudgestack.R

commit 88f4a63
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit 752e476
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit 5271987
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Tue Oct 1 08:51:55 2019 +0200

    Resolve conflict

commit 771918d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit da1e7be
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:37 2019 +0200

    Delete packages from example

commit a1573b3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 59d2b6e
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:50 2019 +0200

    Update vdiffr version

commit 0e80c8a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit 31cc104
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit dc6b78d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit d35ea70
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit 87c00fa
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit f587fb8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:48 2019 +0200

    Add description of position_nudgestack

commit 327a6cd
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:13 2019 +0200

    Add position_nudgestack into description

commit c97d54d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 7fbc0f7
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit 9d894a8
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 56e9b3b
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 4535be6
Author: Mara Alexeev <39673697+MaraAlexeev@users.noreply.github.com>
Date:   Tue Sep 3 08:26:07 2019 -0400

    Clarify documentation in mpg: very minor (tidyverse#3515)

    * add helpful explanation of mpg$drv

commit c8fa99f
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit a290bb3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit bde6844
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Mon Sep 30 14:06:24 2019 +0200

    Use tsbox for converting ts object to tibble

commit 0ee259c
Author: bernie gray <bfgray3@users.noreply.github.com>
Date:   Mon Sep 30 06:54:57 2019 -0400

    default formula argument to NULL in geom_smooth() (tidyverse#3307)

commit fa000f7
Author: Dewey Dunnington <dewey@fishandwhistle.net>
Date:   Sun Sep 29 18:26:36 2019 -0300

    Make position guides customizable (tidyverse#3398, closes tidyverse#3322)

    * Position guides can now be customized using the new `guide_axis()`, which can be passed to position `scale_*()` functions or via `guides()`. The new axis guide (`guide_axis()`) comes with arguments `check.overlap` (automatic removal of overlapping labels), `angle` (easy rotation of axis labels), and `n.dodge` (dodge labels into multiple rows/columns)

    * `CoordCartesian` gets new methods to resolve/train the new position guides

commit 696fe9d
Author: Thomas Knecht <t.knecht@hotmail.com>
Date:   Fri Sep 27 15:58:51 2019 +0200

    Bugfix

commit b027238
Merge: 10b5e24 c32f856
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 16:38:27 2019 +0200

    Merge branch 'Add_position_nudgestack' of https://github.com/TeddyLeeJones/ggplot2 into Add_position_nudgestack

commit 10b5e24
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit 4fb6996
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:37 2019 +0200

    Delete packages from example

commit 823c686
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit e6df407
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:50 2019 +0200

    Update vdiffr version

commit be91893
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit f44e504
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 3713420
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit 9291957
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit ef5aef7
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 42c0fa3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:48 2019 +0200

    Add description of position_nudgestack

commit 548f313
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:13 2019 +0200

    Add position_nudgestack into description

commit 7bb930c
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit 9bd40d6
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit c5022d3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit 8572437
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 3d61c3a
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit 2782c9d
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack

commit c32f856
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Wed Sep 18 15:55:02 2019 +0200

    Add tests for correct nudging and stacking

commit d5c58da
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:37 2019 +0200

    Delete packages from example

commit 015b2e3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:03:12 2019 +0200

    Add validated svg for position_nudgestack

commit 2484f71
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:50 2019 +0200

    Update vdiffr version

commit e2c1fb6
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 18:02:29 2019 +0200

    Add test file with a doppelganger-test

commit a681f59
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:49 2019 +0200

    Add new examples

commit 02f6be4
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:09:20 2019 +0200

    Delete packages from @examples

commit def4755
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 16:06:00 2019 +0200

    Adjust filter criterion in examples

commit c1729d1
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 17 15:39:56 2019 +0200

    Add the zoo-package to Suggestions

commit 5ebe5d4
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:48 2019 +0200

    Add description of position_nudgestack

commit 99b4b5e
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:01:13 2019 +0200

    Add position_nudgestack into description

commit 971b110
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 14:00:28 2019 +0200

    Add position-nudgestack.R into man

commit e5e91ea
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:58:38 2019 +0200

    Add new position_nudgestack into NAMESPACE

commit fedef93
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:56:35 2019 +0200

    Add new position to DESCRIPTION

commit bcc75a3
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Mon Sep 16 13:47:58 2019 +0200

    Add time series example

commit 23e3241
Author: Mara Alexeev <39673697+MaraAlexeev@users.noreply.github.com>
Date:   Tue Sep 3 08:26:07 2019 -0400

    Clarify documentation in mpg: very minor (tidyverse#3515)

    * add helpful explanation of mpg$drv

commit 01d7db0
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:26:32 2019 +0200

    Delete emtpy rows

commit a486906
Author: Thomas Knecht <thomasknecht@Thomass-MacBook-Pro-2.local>
Date:   Tue Sep 3 09:09:06 2019 +0200

    Add position_nudgestack
@lock
Copy link

@lock lock bot commented Apr 2, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants