Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit function devices to use file argument #3810

merged 4 commits into from Feb 24, 2020


Copy link

@bwiernik bwiernik commented Feb 7, 2020

Devices like devEMF::emf or Cairo::CairoSVG use file instead of filename. They currently fail when provided in device to ggsave. This fixes that.

Closes #3807

Copy link

@yutannihilation yutannihilation left a comment

Thanks for catching this! This basically looks good to me. One corner case in my mind is when a function has both file and filename in its arguments, but I expect such functions are very few (or none).

Could you add a NEWS bullet?

R/save.r Outdated Show resolved Hide resolved
bwiernik and others added 2 commits Feb 21, 2020
Co-Authored-By: Hiroaki Yutani <>
Copy link
Contributor Author

bwiernik commented Feb 21, 2020

Okay, fixed the styling and added a NEWS bullet as requested.

NEWS Outdated
* Support graphics devices that use the `file` argument instead of `fileneame`
in `ggsave()` (@bwiernik, 3810)

Copy link

@yutannihilation yutannihilation Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, we are now using instead of NEWS. Could you move this to

@yutannihilation yutannihilation merged commit 53edc51 into tidyverse:master Feb 24, 2020
2 checks passed
Copy link

yutannihilation commented Feb 24, 2020


@bwiernik bwiernik deleted the ggsave-file-arg branch Feb 25, 2020
sthagen added a commit to sthagen/tidyverse-ggplot2 that referenced this issue Feb 25, 2020
Permit function devices to use `file` argument (tidyverse#3810)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

2 participants